Date: Wed, 1 Mar 2017 08:43:55 -0800 (PST) From: "Rodney W. Grimes" <freebsd-rwg@pdx.rh.CN85.dnsmgr.net> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Ian Lepore <ian@freebsd.org>, "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Ngie Cooper <ngie@freebsd.org> Subject: Re: svn commit: r314464 - head/usr.sbin/yppush Message-ID: <201703011643.v21GhtaI057213@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <20170301163050.GA81295@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Wed, Mar 01, 2017 at 08:54:51AM -0700, Ian Lepore wrote:
> > ...
> > You're not the only one who has diffed build output logs (I suspect
> > anyone who has to maintain a non-trivial build infrastructure has done
> > so), and you're not the only one who thinks that changing relative
> > paths to absolute is a bad idea.
>
> +1. Relative paths are so much nicer (and they are usually shorter as
> well). I didn't respond to these changes only because .CURDIR itself
> is expanded to a full path, so arguing if one wants some ../../ within
> what's inherently starts with a slash seems pointless.
True, in the normal use relative paths are shorter, but in how this
actually all goes about the use of ${SRCTOP} vs ${.CURDIR} yeilds
both short strings in the Makefile, and shorter output in the log.
Your reasoning is also why I was somewhat quiet on it when I saw it
start to be merged into -stable, which was the first place I saw it.
I *thought* at that point the whole of -current had already been
converted and this was just coming over with other nearby changes.
I believe we have some other full path things that have crept
forward into the production release, but that may be in ports
only. Nope bad full paths links I found in just a few seconds:
lrwxr-xr-x 1 root wheel 15 Nov 30 02:26 chfn -> /usr/bin/chpass
lrwxr-xr-x 1 root wheel 15 Nov 30 02:26 chsh -> /usr/bin/chpass
lrwxr-xr-x 1 root wheel 7 Nov 30 02:27 cpio -> bsdcpio
lrwxr-xr-x 1 root wheel 21 Nov 30 02:27 mailq -> /usr/sbin/mailwrapper
lrwxr-xr-x 1 root wheel 21 Nov 30 02:27 newaliases -> /usr/sbin/mailwrapper
lrwxr-xr-x 1 root wheel 10 Nov 30 02:25 pgrep -> /bin/pgrep
lrwxr-xr-x 1 root wheel 10 Nov 30 02:25 pkill -> /bin/pkill
lrwxr-xr-x 1 root wheel 6 Nov 30 02:27 tar -> bsdtar
lrwxr-xr-x 1 root wheel 15 Nov 30 02:26 ypchfn -> /usr/bin/chpass
lrwxr-xr-x 1 root wheel 15 Nov 30 02:26 ypchpass -> /usr/bin/chpass
lrwxr-xr-x 1 root wheel 15 Nov 30 02:26 ypchsh -> /usr/bin/chpass
lrwxr-xr-x 1 root wheel 15 Nov 30 02:27 yppasswd -> /usr/bin/passwd
This breaks the abilty to mv usr/bin and have the right stuff
happen if you invoke usr/bin.moved/mailq.
--
Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201703011643.v21GhtaI057213>