Date: Mon, 4 Feb 2002 19:06:54 -0800 From: Kris Kennaway <kris@obsecurity.org> To: David O'Brien <obrien@FreeBSD.org> Cc: Ruslan Ermilov <ru@FreeBSD.org>, Mark Murray <markm@FreeBSD.org>, current@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: pam_ssh world breakage (was: Re: cvs commit: src/lib/libpam Makefile.inc) Message-ID: <20020204190654.B36742@xor.obsecurity.org> In-Reply-To: <20020204091717.A16149@dragon.nuxi.com>; from obrien@FreeBSD.org on Mon, Feb 04, 2002 at 09:17:17AM -0800 References: <200202031551.g13Fpql76999@freefall.freebsd.org> <20020204153032.C58535@sunbay.com> <20020204091717.A16149@dragon.nuxi.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Mon, Feb 04, 2002 at 09:17:17AM -0800, David O'Brien wrote: > On Mon, Feb 04, 2002 at 03:30:32PM +0200, Ruslan Ermilov wrote: > > This delta breaks buildworld. gcc(1) has a known bug-feature > > of hiding some errors in standard system headers, making them > > invisible without -I. > ... > > and compile now can't survive the WARNS=4. > > Not to mention there is ZERO way this code will pass WARNS=4 for GCC 3. > Please Committers, do not try to WARNS code right now -- there just is no > use. It will only get in the way later. If a new compiler generates more warnings then we should temporarily disable the warnings when the compiler is imported by setting WARNS=0 in <bsd.sys.mk>. All of the Makefile.inc's which set a default WARNS value for a subdirectory use WARNS?= for this reason (so they can be globally overridden until someone goes through and fixes the new ones). If you use the argument that one shouldn't set WARNS because a new compiler will cause the tree to break, then there's no point having it at all since that condition will always be true. Kris [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE8X0xNWry0BWjoQKURAlc8AKDGpW9H6S7aoQLIVX9bEFRSShoW+ACfeaBP RhZX3q1QY+ZmJ0BeOlak2HY= =sxPF -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020204190654.B36742>