Date: Sun, 18 Jul 2004 09:51:06 -0700 From: Sam Leffler <sam@errno.com> To: David Malone <dwmalone@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/linux linux_socket.c Message-ID: <200407180951.06333.sam@errno.com> In-Reply-To: <200407180926.i6I9QYoB082932@repoman.freebsd.org>
index | next in thread | previous in thread | raw e-mail
On Sunday 18 July 2004 02:26 am, David Malone wrote: > dwmalone 2004-07-18 09:26:34 UTC > > FreeBSD src repository > > Modified files: > sys/compat/linux linux_socket.c > Log: > I missed two pieces of the commit to this file. Robert has already > added one, this adds the other. Not to pick on this commit, but recently there have been several commits where the log msg addressed _why_ the commit was done but never described _what_ was changed. This is not helpful; someone coming along later with only CVS for reference must do a diff to even guess what the change does. Good commit msgs give a reader an understanding of the reason and content of a change. The above commit msg is more appropriate as followup mail to the actual commit (so it's not even included in CVS). Samhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200407180951.06333.sam>