Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 30 Nov 2016 23:42:25 +0000
From:      "rstone (Ryan Stone)" <phabric-noreply@FreeBSD.org>
To:        freebsd-net@freebsd.org
Subject:   [Differential] D8685: Fix a false positive in a buf_ring assert
Message-ID:  <2f6c8087c004c67d3091cb6cd51f81ea@localhost.localdomain>
In-Reply-To: <differential-rev-PHID-DREV-7bpwu3y3lzsbz4zoj3jc-req@FreeBSD.org>
References:  <differential-rev-PHID-DREV-7bpwu3y3lzsbz4zoj3jc-req@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

rstone marked an inline comment as done.
rstone added inline comments.

INLINE COMMENTS

> hselasky wrote in buf_ring.h:71
> should "br->br_cons_head + 1" be masked by br->br_cons_mask ??

Absolutely correct.  Nice catch, thank you

REVISION DETAIL
  https://reviews.freebsd.org/D8685

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: rstone
Cc: hselasky, freebsd-net-list, emaste


Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2f6c8087c004c67d3091cb6cd51f81ea>