Date: Fri, 6 Jul 2018 09:56:55 +0000 From: Brooks Davis <brooks@freebsd.org> To: Matthew Macy <mat.macy@gmail.com> Cc: Brooks Davis <brooks@freebsd.org>, Ravi Pokala <rpokala@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335979 - in head: . lib/libkvm sys/kern sys/netinet sys/sys usr.bin/netstat usr.bin/sockstat Message-ID: <20180706095655.GA83113@spindle.one-eyed-alien.net> In-Reply-To: <CAPrugNrN1wY4OzsUm1PGXf-NBu%2Bd44fpCKR5SUnsiWvtuqLWTQ@mail.gmail.com> References: <201807051313.w65DDnQJ041281@repo.freebsd.org> <A607A367-329C-4627-84E8-0C4D16C8085D@panasas.com> <20180705163338.GA67089@spindle.one-eyed-alien.net> <CAPrugNrN1wY4OzsUm1PGXf-NBu%2Bd44fpCKR5SUnsiWvtuqLWTQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--pf9I7BMVVzbSWLtt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Sorry about that. I'm working on it. -- brooks On Thu, Jul 05, 2018 at 06:45:33PM -0700, Matthew Macy wrote: > this breaks the MIPS builds. >=20 > On Thu, Jul 5, 2018 at 9:33 AM, Brooks Davis <brooks@freebsd.org> wrote: > > On Thu, Jul 05, 2018 at 09:10:54AM -0700, Ravi Pokala wrote: > >> Hi Brooks, > >> > >> -----Original Message----- > >> From: <owner-src-committers@freebsd.org> on behalf of Brooks Davis <br= ooks@FreeBSD.org> > >> Date: 2018-07-05, Thursday at 06:13 > >> To: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-= head@freebsd.org> > >> Subject: svn commit: r335979 - in head: . lib/libkvm sys/kern sys/neti= net sys/sys usr.bin/netstat usr.bin/sockstat > >> > >> > Author: brooks > >> > Date: Thu Jul 5 13:13:48 2018 > >> > New Revision: 335979 > >> > URL: https://svnweb.freebsd.org/changeset/base/335979 > >> > > >> > Log: > >> > Make struct xinpcb and friends word-size independent. > >> > > >> > Replace size_t members with ksize_t (uint64_t) and pointer members > >> > (never used as pointers in userspace, but instead as unique > >> > idenitifiers) with kvaddr_t (uint64_t). This makes the structs > >> > identical between 32-bit and 64-bit ABIs. > >> ... > >> > Modified: head/UPDATING > >> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D > >> > --- head/UPDATING Thu Jul 5 11:50:59 2018 (r335978) > >> > +++ head/UPDATING Thu Jul 5 13:13:48 2018 (r335979) > >> > @@ -31,6 +31,14 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 12.x IS SLO= W: > >> > disable the most expensive debugging functionality run > >> > "ln -s 'abort:false,junk:false' /etc/malloc.conf".) > >> > > >> > +20180705: > >> > + The ABI of syscalls used by management tools like sockstat and > >> > + netstat has been broken to allow 32-bit binaries to work on > >> > + 64-bit kernels without modification. > >> > >> Isn't that what the compat32 layer is for? > > > > compat32 isn't magic. If one tried, one could hardly design structures > > to make 32-bit compat harder then the previous versions. It's certainly > > possible to make work, but quite annoying. Since the ABI of most these > > structures was already broken for 12, I chose this approach as it is > > quite trivial. > > > >> > These programs will need > >> > + to match the kernel in order to function. External programs may > >> > + require minor modifications to accommodate a change of type in > >> > + structures from pointers to 64-bit virtual addresses. > >> > >> Doesn't this contradict the earlier statement about letting things run= unmodified? > > > > Unmodified post this commit. We already don't support netstat and > > sockstat from 11 on 12 in any architecture combination. > > > > -- Brooks >=20 --pf9I7BMVVzbSWLtt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJbPzzmAAoJEKzQXbSebgfAd+sH/0j2jVlxY2Ei3YWrXyqxuk0w 45t6+wbAG7JwIMXwj5QxtmvCQRwmF3M3YdHAd97nMkjzqhpasmid44g1NUSG4xw/ MJbTyiQ2w/I2Cs41RQVu/cVmtRBQfegLGXxygqneLTw6e1oFh/CL/EE7xsZtZa2A 3MNhgz3LF62nbHJlv11QuZC4EUr9CFd9uWgRC/Ai5VpA5lFPCdNM2WF0kSxYuVvC qkzF5d39ufWZgXEIMccfJFNkIus1jQ3lwNajmojBNlZJNP/oSz5F2SAtelMzBvGQ aN2ytJEDEq8vFlAOJ0BOUIdUa4y6jMf1kQkQQcnveYIQUHsfIwUSFfhDvuJ6lBU= =+o0S -----END PGP SIGNATURE----- --pf9I7BMVVzbSWLtt--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180706095655.GA83113>