Date: Fri, 3 Nov 2017 16:07:48 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Warner Losh <imp@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r325116 - head Message-ID: <3a0a92dd-19fc-2ee3-dcbf-224e4c2e8eec@FreeBSD.org> In-Reply-To: <a5f57322-3dfe-0cd2-0366-0eea064327cb@FreeBSD.org> References: <201710300312.v9U3CcCT021416@repo.freebsd.org> <8d9e9f50-035c-403c-3bc5-6788b7a94dea@FreeBSD.org> <CANCZdfpXuLkS843%2BjneBzCYCsM5ZvV_Tm=zxzt73-wiD3C2%2BLg@mail.gmail.com> <72ee6c6d-0d9a-ebe9-8e15-c278fc91ded2@FreeBSD.org> <CANCZdfr6s0wWs%2BjYCVjAVEj0c_=5PGGz%2BnU-u8O61snNQjPKkQ@mail.gmail.com> <a5f57322-3dfe-0cd2-0366-0eea064327cb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RT9PpvcCdeKiAuuOEmEuJfv0g5WAKc1oW Content-Type: multipart/mixed; boundary="gr7fhuPW44ivwpOwfh6vEwx69rcmtKqlR"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Warner Losh <imp@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Message-ID: <3a0a92dd-19fc-2ee3-dcbf-224e4c2e8eec@FreeBSD.org> Subject: Re: svn commit: r325116 - head References: <201710300312.v9U3CcCT021416@repo.freebsd.org> <8d9e9f50-035c-403c-3bc5-6788b7a94dea@FreeBSD.org> <CANCZdfpXuLkS843+jneBzCYCsM5ZvV_Tm=zxzt73-wiD3C2+Lg@mail.gmail.com> <72ee6c6d-0d9a-ebe9-8e15-c278fc91ded2@FreeBSD.org> <CANCZdfr6s0wWs+jYCVjAVEj0c_=5PGGz+nU-u8O61snNQjPKkQ@mail.gmail.com> <a5f57322-3dfe-0cd2-0366-0eea064327cb@FreeBSD.org> In-Reply-To: <a5f57322-3dfe-0cd2-0366-0eea064327cb@FreeBSD.org> --gr7fhuPW44ivwpOwfh6vEwx69rcmtKqlR Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 11/3/2017 4:04 PM, Bryan Drewery wrote: > On 11/3/2017 3:45 PM, Warner Losh wrote: >> >> >> On Fri, Nov 3, 2017 at 4:40 PM, Bryan Drewery <bdrewery@freebsd.org >> <mailto:bdrewery@freebsd.org>> wrote: >> >> On 11/3/2017 3:32 PM, Warner Losh wrote: >> > >> > >> > On Fri, Nov 3, 2017 at 4:28 PM, Bryan Drewery <bdrewery@freebsd.= org <mailto:bdrewery@freebsd.org> >> > <mailto:bdrewery@freebsd.org <mailto:bdrewery@freebsd.org>>> wro= te: >> > >> >=C2=A0 =C2=A0 =C2=A0On 10/29/2017 8:12 PM, Warner Losh wrote: >> >=C2=A0 =C2=A0 =C2=A0> Author: imp >> >=C2=A0 =C2=A0 =C2=A0> Date: Mon Oct 30 03:12:38 2017 >> >=C2=A0 =C2=A0 =C2=A0> New Revision: 325116 >> >=C2=A0 =C2=A0 =C2=A0> URL: https://svnweb.freebsd.org/changeset/b= ase/325116 >> <https://svnweb.freebsd.org/changeset/base/325116>; >> >=C2=A0 =C2=A0 =C2=A0<https://svnweb.freebsd.org/changeset/base/32= 5116 >> <https://svnweb.freebsd.org/changeset/base/325116>>; >> >=C2=A0 =C2=A0 =C2=A0> >> >=C2=A0 =C2=A0 =C2=A0> Log: >> >=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0Return proper status from build= env. >> >=C2=A0 =C2=A0 =C2=A0> >> >=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0make buildenv BUILDENV_SHELL=3D= <some command> more useful. >> Remove '|| >> >=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0true' from the command line so = that errors are properly >> >=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0returned. There appears to be n= o reason for it, and it >> dates back to >> >=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0the original commit by ru@. >> >=C2=A0 =C2=A0 =C2=A0> >> >=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0Sponsored by: Netflix >> > >> >=C2=A0 =C2=A0 =C2=A0Now simply running 'make buildenv' and 'exit'= throws a make error. >> > >> >=C2=A0 =C2=A0 =C2=A0Perhaps we need a BUILDENV_CMDS that does wha= t you want and we >> otherwise >> >=C2=A0 =C2=A0 =C2=A0leave the ${BUILDENV_SHELL} || true handling.= >> > >> > >> > Are you sure? >> > >> > 4:29pm zooty:[242]> make buildenv >> > Entering world for amd64:amd64 >> > $ exit >> > 4:29pm zooty:[243]> >> > >> > Perhaps you can give me an example that causes that? This was th= e very >> > first thing I checked before committing the fix... >> > >> >> Only happens with zsh. >> >> > [root@c1100-1][pts/8][zsh/2][Fri 11/03/2017 15:40:10 PDT][0?2&] >> (git-svn)-[master]- >> > ~/git/freebsd # BUILDENV_SHELL=3Dcsh make buildenv >> > Entering world for amd64:amd64 >> > root@c1100-1:~/git/freebsd # exit >> > exit >> > ~/git/freebsd # BUILDENV_SHELL=3D/usr/local/bin/zsh make builden= v >> > Entering world for amd64:amd64 >> > For ZSH you must run: export CPUTYPE=3D >> > (buildenv) [root@c1100-1][pts/8][zsh/3][Fri 11/03/2017 15:40:23 >> PDT][1?0&] (git-svn)-[master]- >=20 > The 1? above means the last command returned 1. Hmm, I wonder why. It's my own .zshrc, ignore me. >=20 >> > ~/git/freebsd # exit >> > *** Error code 1 >> > >> > Stop. >> > make[1]: stopped in /root/git/freebsd >> > *** Error code 1 >> > >> > Stop. >> > make: stopped in /root/git/freebsd >> >> >> Shouldn't this be fixed in upstream zsh rather than yet another ZSH wa= rt >> in the buildsystem that literally has another ZSH wart in the same lin= e? >> >> Warner >=20 >=20 --=20 Regards, Bryan Drewery --gr7fhuPW44ivwpOwfh6vEwx69rcmtKqlR-- --RT9PpvcCdeKiAuuOEmEuJfv0g5WAKc1oW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJZ/PbEAAoJEDXXcbtuRpfP9oMH/0FZVVNIIfirOusXZ7tdfIVT nLY9SExFG2WfGmBqvTreowfe4W12t2ndd2GL5bbYFurq9d/vtz1oQ+iggM4JzCQj C0Mm4BB/I22edHY5r4OIOVwU4jSvd2K0Si6ve7DLa3sQ4E9MPFh/3sOVpw7qsw2r 1C2ivOnIWLAj5NANVcZY9lQRL5bGXvjp1esy2SPB4BgusnuxVAc6Mb6dVI7cbyqG ZF42HycG1sbDCQgfiYHgeCvH9BzMzpJkoc0lsfaw1rcDMYzy5Tb4xPFkxjSWseLt 4peMP/GvtDdXv6Y7UA1ahuCFNUIircHxtKVhzZz+0J6GFY6S28Rnyf8BB4Oaqx4= =CNo9 -----END PGP SIGNATURE----- --RT9PpvcCdeKiAuuOEmEuJfv0g5WAKc1oW--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3a0a92dd-19fc-2ee3-dcbf-224e4c2e8eec>