Date: Wed, 26 Apr 2023 05:36:52 GMT From: Kyle Evans <kevans@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 3a5855dd220b - main - gbde: stop rebuilding sha512 bits Message-ID: <202304260536.33Q5aqPA029814@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=3a5855dd220b00ab8b1c94a95e2e44cdddb8417e commit 3a5855dd220b00ab8b1c94a95e2e44cdddb8417e Author: Kyle Evans <kevans@FreeBSD.org> AuthorDate: 2023-04-26 05:36:33 +0000 Commit: Kyle Evans <kevans@FreeBSD.org> CommitDate: 2023-04-26 05:36:33 +0000 gbde: stop rebuilding sha512 bits In the early days of gbde, it linked against libmd. Shortly after conception, phk replaced ARC4 with SHA-512, but libmd did not have SHA2 at the time thus he built a copy of sha2.c for gbde. Fast forward 3 years, cperciva adds SHA2 to libmd -- this makes gbde's build of sha2.c redundant, but it's (understandably) overlooked. Let's simplify the gbde build now and just assume that libmd includes the most optimal implementation. Reported by: koobs (weird lto errors?) Differential Revision: https://reviews.freebsd.org/D34668 --- sbin/gbde/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/sbin/gbde/Makefile b/sbin/gbde/Makefile index 867a7f8e9b55..b1ee8edb9d80 100644 --- a/sbin/gbde/Makefile +++ b/sbin/gbde/Makefile @@ -5,7 +5,6 @@ PROG= gbde SRCS= gbde.c template.c SRCS+= rijndael-alg-fst.c SRCS+= rijndael-api-fst.c -SRCS+= sha512c.c SRCS+= g_bde_lock.c # rijndael-fst.c does evil casting things which can results in warnings,
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202304260536.33Q5aqPA029814>