Date: Wed, 28 May 2014 16:49:04 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Hans Petter Selasky <hselasky@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r266798 - head/usr.sbin/usbdump Message-ID: <20140528124904.GI50679@FreeBSD.org> In-Reply-To: <201405281227.s4SCRgKs038491@svn.freebsd.org> References: <201405281227.s4SCRgKs038491@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, May 28, 2014 at 12:27:42PM +0000, Hans Petter Selasky wrote: H> Author: hselasky H> Date: Wed May 28 12:27:41 2014 H> New Revision: 266798 H> URL: http://svnweb.freebsd.org/changeset/base/266798 H> H> Log: H> Fix for big endian architectures. The "up_address" field is 8-bit and H> does not need byte swapping. H> H> MFC after: 1 week Do we need the assignment then? I'm surprised that compiler doesn't fail on that. H> Modified: H> head/usr.sbin/usbdump/usbdump.c H> H> Modified: head/usr.sbin/usbdump/usbdump.c H> ============================================================================== H> --- head/usr.sbin/usbdump/usbdump.c Wed May 28 11:30:37 2014 (r266797) H> +++ head/usr.sbin/usbdump/usbdump.c Wed May 28 12:27:41 2014 (r266798) H> @@ -473,7 +473,7 @@ print_apacket(const struct header_32 *hd H> */ H> up->up_totlen = le32toh(up->up_totlen); H> up->up_busunit = le32toh(up->up_busunit); H> - up->up_address = le32toh(up->up_address); H> + up->up_address = up->up_address; H> up->up_flags = le32toh(up->up_flags); H> up->up_status = le32toh(up->up_status); H> up->up_error = le32toh(up->up_error); -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140528124904.GI50679>