Date: Thu, 1 Nov 2012 18:07:47 +0000 From: Chris Rees <crees@FreeBSD.org> To: Florian Smeets <flo@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, tmseck@web.de, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r306768 - in head/www/squid32: . files Message-ID: <CADLo8398pEz3gRPfxsWA_0z3n92gC=A0mZ-x9R0wefYKFmQa1g@mail.gmail.com> In-Reply-To: <201210312155.q9VLtPMA040921@svn.freebsd.org> References: <201210312155.q9VLtPMA040921@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 31 October 2012 21:55, Florian Smeets <flo@freebsd.org> wrote: > XXX Ports RC script present > Author: flo > Date: Wed Oct 31 21:55:25 2012 > New Revision: 306768 > URL: http://svn.freebsd.org/changeset/ports/306768 > > Log: > - fix process detection in Squid's rc.d script [1] > - remove a leftover substitution with a hard coded value > - remove a few comments which were accidentally left in from development > - rework the code that deals with kerberos negotiate auth a bit > - bump PORTREVISION for the squid rc.d script update > > PR: ports/173236 [1] http://www.FreeBSD.org/cgi/query-pr.cgi?pr=173236 > PR: ports/173248 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=173248 > Submitted by: Thomas-Martin Seck <tmseck@web.de> (maintainer) > Reported by: Leonid Nevecherya <nlv@imbera.ru> [1] > Feature safe: yes > > Modified: > head/www/squid32/Makefile > head/www/squid32/files/squid.in I've made some minor style fixes to Squid's rc script, mostly making sure the code is in the right order and using the less verbose style for setting defaults to make it clearer that they're setting themselves. Thomas, is this patch OK? http://www.bayofrum.net/~crees/patches/squid-style-fixes.diff Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo8398pEz3gRPfxsWA_0z3n92gC=A0mZ-x9R0wefYKFmQa1g>