Date: Thu, 18 Jan 1996 22:02:25 -0800 (PST) From: Julian Elischer <julian@ref.tfs.com> To: sysseh@devetir.qld.gov.au (Stephen Hocking) Cc: bugs@freebsd.org Subject: Re: kern/951: DEVFS panic with SCSI tape (fix found!) Message-ID: <199601190602.WAA06105@ref.tfs.com> In-Reply-To: <199601190505.FAA23894@netfl15a.devetir.qld.gov.au> from "Stephen Hocking" at Jan 19, 96 03:05:05 pm
next in thread | previous in thread | raw e-mail | index | archive | help
HANG ON! How can this be? All it is doing is using sprintf on that buffer, and all the occurances are about 8 characters long.. the buffer is 32 bytes long.. exactly WHAT names are appearing in the DEVFS? it only puts the device name part into the string, not the full path name.. eh? yours confusedly julian > > I've found a fix for this - the DEVFS code was overrunning a buffer in st.c, > causing it to do strange & terrible things to other stuff on the stack. To > fix, change line 276 of /sys/scsi/st.c to be > > static char name[128]; > > It all works now, can someone commit a change (and probably review the > buffersize for this stuff that DEVFS uses? I see some other errors (nothing > fatal) on another relating to the psm0 device abouth not being able to > allocate a name slot.) > > > Stephen > -- > > I do not speak for the Worker's Compensation Board of Queensland - > They don't pay me enough for that! > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199601190602.WAA06105>