Date: Sat, 20 Mar 2010 13:28:16 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Kip Macy <kmacy@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r205231 - in head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs: . sys Message-ID: <20100320122816.GG1733@garage.freebsd.pl> In-Reply-To: <20100320110219.GD1733@garage.freebsd.pl> References: <201003162217.o2GMHMjU012285@svn.freebsd.org> <20100320110219.GD1733@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Sat, Mar 20, 2010 at 12:02:19PM +0100, Pawel Jakub Dawidek wrote: > On Tue, Mar 16, 2010 at 10:17:22PM +0000, Kip Macy wrote: > > Author: kmacy > > Date: Tue Mar 16 22:17:21 2010 > > New Revision: 205231 > > URL: http://svn.freebsd.org/changeset/base/205231 > > > > Log: > > - reduce contention by breaking up ARC state locks in to 16 for data > > and 16 for metadata > > - export L2ARC tunables as sysctls > > - add several kstats to track L2ARC state more precisely > > - avoid holding a contended lock when atomically incrementing a > > contended counter (no lock protection needed for atomics) > > Kip, don't get me wrong, I appreciate you're working on ZFS, but... > > I'm still working on ZFS, trying hard to bring it up-to-date and such > invasive changes don't make it easier. > > I'm not against invasive changes in general, but I want them to be > reviewed and tested properly. We discussed this multiple times and I > thought the consensus was to provide hard number and workload examples > that will prove the change really helps. And if it helps, present the > finding to Sun/Oracle guys to get the changes into OpenSolaris, which is > good for everyone: OpenSolaris gets faster ZFS, FreeBSD gets less pain > in keeping ZFS up-to-date. > > Can I ask you to prepare description of the workload it helps, benchmark > it and present the numbers on zfs-code@opensolaris.org? > > The ZFS team is built from really smart and mature developers. I'm sure > that if the change is properly described with prove included they will > accept it and the world will be a bit better place to live for everyone. Take a look at: http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6581122 -- Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkukv2AACgkQForvXbEpPzRzAACgywRHCXf3qa6Jaf4PAUob8pgL nOsAn3dX/uXbVmYUNtp2FuLr/lQ5pGB1 =b0zW -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100320122816.GG1733>