Date: Mon, 29 Oct 2007 05:42:36 +0300 From: Andrey Chernov <ache@nagual.pp.ru> To: Ken Smith <kensmith@cse.Buffalo.EDU> Cc: Scott Long <scottl@samsco.org>, src-committers@FreeBSD.ORG, d@delphij.net, John Baldwin <jhb@FreeBSD.ORG>, cvs-src@FreeBSD.ORG, Rong-en Fan <grafan@gmail.com>, Robert Watson <rwatson@FreeBSD.ORG>, imp@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/locale utf8.c Message-ID: <20071029024236.GA99115@nagual.pp.ru> In-Reply-To: <1193616095.18844.19.camel@opus.cse.buffalo.edu> References: <20071025233536.B99770@fledge.watson.org> <472120E8.90504@samsco.org> <200710261144.34645.jhb@freebsd.org> <472217C2.8020800@samsco.org> <6eb82e0710260954m73b3f17bq2c72a4cdb597640e@mail.gmail.com> <6eb82e0710270130o5557efew95f62aef8035d209@mail.gmail.com> <20071027092213.GA53271@nagual.pp.ru> <6eb82e0710280154h68393dcag4e9ba4ac4c219065@mail.gmail.com> <20071028211306.GA91223@nagual.pp.ru> <1193616095.18844.19.camel@opus.cse.buffalo.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
--3MwIy2ne0vdjdPXF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 28, 2007 at 08:01:35PM -0400, Ken Smith wrote: > On Mon, 2007-10-29 at 00:13 +0300, Andrey Chernov wrote: > > On Sun, Oct 28, 2007 at 04:54:52PM +0800, Rong-en Fan wrote: > > > > As a small improvement, we can skip __isctype() from this list too = and > > > > just hardcode 128 there, i.e.: return (_c < 0 || _c >=3D 128) ... > > > > since default locale never define anything above 128. > > >=20 > > > Thank you. A new patch is available at > > >=20 > > > http://people.freebsd.org/~rafan/ctype-abi-fix-6-try2.diff > >=20 > > Looks OK. Please don't forget MFC __isctype changes to 7x too. > >=20 >=20 > The portmgr@ folks are holding off on HEAD package builds (for > packages-8-current) for things to settle out at least in HEAD. Are we > in what should be the final state of things for HEAD now or are more > tweaks there coming? I think I try my best to make this ctype fix and no more tweaks left. But= =20 please keep in mind that I can't preciously predict related to releases=20 problems, because I have only -current on my machines (so why rafan@ gives= =20 his help). Of course I can't 100% guarantee "no new stuff" thing because=20 some new idea may apears in anytime to improve this thing :) --=20 http://ache.pp.ru/ --3MwIy2ne0vdjdPXF Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFHJUicVg5YK5ZEdN0RAjoqAKCEbATaNw8+fZSklIvyRkYIZc7ItwCfRa/0 HjshaP0k/Idzd+xg5ugIOao= =4E3H -----END PGP SIGNATURE----- --3MwIy2ne0vdjdPXF--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071029024236.GA99115>