Date: Fri, 28 Oct 2005 00:59:21 +0400 From: Roman Kurakin <rik@cronyx.ru> To: obrien@FreeBSD.org Cc: Roman Kurakin <rik@FreeBSD.org>, cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/cp if_cp.c Message-ID: <43613FA9.8000005@cronyx.ru> In-Reply-To: <20051027074053.GA24024@dragon.NUXI.org> References: <200509271657.j8RGvj2n015326@repoman.freebsd.org> <20051024072423.GA34909@dragon.NUXI.org> <20051027074053.GA24024@dragon.NUXI.org>
next in thread | previous in thread | raw e-mail | index | archive | help
David O'Brien:
>On Mon, Oct 24, 2005 at 12:24:23AM -0700, David O'Brien wrote:
>
>
>>On Tue, Sep 27, 2005 at 04:57:45PM +0000, Roman Kurakin wrote:
>>
>>
>>>rik 2005-09-27 16:57:45 UTC
>>>
>>> FreeBSD src repository
>>>
>>> Modified files:
>>> sys/dev/cp if_cp.c
>>> Log:
>>> Restore if_cp.c 1.27
>>> ----------------------------
>>> revision 1.27
>>> date: 2005/09/19 03:10:16; author: imp; state: Exp; lines: +3 -2
>>> Make sure that we call if_free(ifp) after bus_teardown_intr. Since we
>>> could get an interrupt after we free the ifp, and the interrupt
>>> handler depended on the ifp being still alive, this could, in theory,
>>> cause a crash. Eliminate this possibility by moving the if_free to
>>> after the bus_teardown_intr() call.
>>>
>>> In fact, this change do nothing for this driver. It is protected from
>>> this by cp_destroy variable. This variable also protects driver from
>>> initiation of any activity from network stack with disabled intr
>>> handler with this change applied.
>>>
>>>
>>You should not have backed out my commit without discussing it with me
>>and understanding the reason for the change.
>>Do it again and I *will* be taking it Core.
>>
>>
>
>rik, I'm sorry this reads as such an aggressive email. I thought we were in a discussion about the reason of my commit and was surprised to see your commit happened in the middle of what I thought was an on-going thread.
>
>
I do not argue about why you do not ask me before commiting,
I've just asked to not commit changes with big diffs and wonder
if my view of change is ok and if not why.
Your commit was done without asking me cause I am not listed in
Mantainers, I've commited my view of your fix after about a week
of silence from you. So I guess there was now misbehaviour in
each other action.
This is social part of question. And I hope it is closed.
But the technical (from my point of view) is not clean. I still do
not have an answer if there is a problem in my commit that affects
some systems and how many of them. Could this problem be reproduced
with code from CVS (at some interval) or it could be seen only in
some special case. I faild to find the list of bugs for all version of gcc.
Best regards,
Roman Kurakin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?43613FA9.8000005>