Date: Mon, 16 Feb 2026 03:18:43 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@FreeBSD.org> To: Eugene Grosbein <eugen@freebsd.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 8f8a7f6fffd7 - main - libfetch: apply timeout to SSL_read() Message-ID: <86fr711ldo.fsf@ltc.des.dev> In-Reply-To: <a3a2f7b9-34d8-2253-f0f4-efc371d84e82@freebsd.org> (Eugene Grosbein's message of "Mon, 16 Feb 2026 09:06:02 %2B0700") References: <6971e2fa.d8f3.445991e5@gitrepo.freebsd.org> <86pl651mku.fsf@ltc.des.dev> <a3a2f7b9-34d8-2253-f0f4-efc371d84e82@freebsd.org>
index | next in thread | previous in thread | raw e-mail
Eugene Grosbein <eugen@FreeBSD.org> writes: > [moving to developers] [moving back where it belongs] > Dag-Erling Smørgrav <des@FreeBSD.org> writes: > > I did not review or approve this, and it is incorrect. > Sorry, I did not check MAINTAINERS, indeed. Mea culpa. > But, why is it incorrect? It was tested by other users of FreeBSD and > it works for me and them. * It has almost as many style violations as lines of code. * It's in the wrong place. You're calling setsockopt() once per read operation instead of once per connection. * It doesn't fix unencrypted connections. * It's the wrong solution. As explained in code comments, libfetch was designed to work with non-blocking sockets. All you needed to do was restore the fcntl() call that was accidentally dropped a while ago. DES -- Dag-Erling Smørgrav - des@FreeBSD.orghome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86fr711ldo.fsf>