Date: Wed, 1 Jun 2016 13:23:13 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Glen Barber <gjb@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r301163 - in head: etc libexec/dma/dmagent Message-ID: <d2a505d0-8eab-8019-58d5-4597f12482c9@FreeBSD.org> In-Reply-To: <20160601202221.GP75780@FreeBSD.org> References: <201606012006.u51K6t0d012285@repo.freebsd.org> <0933c625-d329-6c4c-88ba-093ad955d475@FreeBSD.org> <20160601202221.GP75780@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --veP29UdGKMKUwMgE2v2N3xJEAgsd0IA80 Content-Type: multipart/mixed; boundary="s1o4j1gUQ8BLTUtapMUuViQrLxRFmn1CG" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Glen Barber <gjb@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <d2a505d0-8eab-8019-58d5-4597f12482c9@FreeBSD.org> Subject: Re: svn commit: r301163 - in head: etc libexec/dma/dmagent References: <201606012006.u51K6t0d012285@repo.freebsd.org> <0933c625-d329-6c4c-88ba-093ad955d475@FreeBSD.org> <20160601202221.GP75780@FreeBSD.org> In-Reply-To: <20160601202221.GP75780@FreeBSD.org> --s1o4j1gUQ8BLTUtapMUuViQrLxRFmn1CG Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 6/1/16 1:22 PM, Glen Barber wrote: > On Wed, Jun 01, 2016 at 01:13:20PM -0700, Bryan Drewery wrote: >> On 6/1/16 1:06 PM, Glen Barber wrote: >>> Author: gjb >>> Date: Wed Jun 1 20:06:55 2016 >>> New Revision: 301163 >>> URL: https://svnweb.freebsd.org/changeset/base/301163 >>> >>> Log: >>> Implement a hack to re-enable installation of the dma.conf. >>> =20 >>> The 'CONFS' entries in share/mk/bsd.confs.mk explicitly check >>> for the 'installconfig', but does not behave properly with the >>> 'distribute' target. >>> =20 >> >> This just moves something out of installconfig, leaving it apparently >> still broken. >> >> Please revert this and r301137 and lets fix this properly. I'm pretty= >> surprised by this. >> >=20 > I'm happy to revert these two commits, they were never intended to be > a permanent fix (I probably should have noted that in the commit log). >=20 > I'm still wrapping my head around what share/mk/bsd.confs.mk is trying > to do, and why it is interfering with installing these files. >=20 > Before these are reverted, do you have an idea in mind of a proper fix?= >=20 What's the bug? make distribution works fine. Just tested rm -rf /tmp/blah make distrib-dirs DESTDIR=3D/tmp/blah make distribution DESTDIR=3D/tmp/blah files present: -rw-r--r-- 1 root wheel 2163 Jun 1 13:21 /tmp/blah/etc/dma/dma.conf -rw------- 1 root wheel 1082 Jun 1 13:21 /tmp/blah/etc/ppp/ppp.conf --=20 Regards, Bryan Drewery --s1o4j1gUQ8BLTUtapMUuViQrLxRFmn1CG-- --veP29UdGKMKUwMgE2v2N3xJEAgsd0IA80 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJXT0QyAAoJEDXXcbtuRpfPOWoIAMu1XOweVfLhuna32mgXlQgN 9i8+nIG6YKociD3ii6hZT7iZN5rKSdcBvBoohoNdv8bWcl0C17yS4nHQPHkQotDb me5fUSceo28wBlWyoSKyTQcdFyfdO11XmJFP7MWaNcxq3wh831DxdKa9jPdMzaG4 dV9eTuumaB41iHAcODN9zixk+gpphtEqPFpn9EGmLNi6BojkolwOK4rEM5rjdvC7 2HdYukQmp0mPQYaTvXX0pFpfPJPVsgWHjXWaaGTAW3261pxiDv8KTwLhLYrl4pUi XBCbB4fwBCdl22EC46wl7w7DmoDdEgKRAh0UbYVCDy8bKqIxNkNIc6QaTx3X/rc= =OjQz -----END PGP SIGNATURE----- --veP29UdGKMKUwMgE2v2N3xJEAgsd0IA80--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d2a505d0-8eab-8019-58d5-4597f12482c9>