Date: Sat, 27 May 2023 13:55:23 -0700 From: Enji Cooper <yaneurabeya@gmail.com> To: Peter Holm <pho@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: acfb06062a68 - main - stress2: Fix warnings Message-ID: <605A888E-8907-4B20-8922-86511E383377@gmail.com> In-Reply-To: <ZHJbdxDGUiw%2Bgvqk@Peters-MacBook-Air.local> References: <202305270835.34R8ZA3g041896@gitrepo.freebsd.org> <41908493-F312-4BA2-A72B-B3C047656CCC@gmail.com> <ZHJbdxDGUiw%2Bgvqk@Peters-MacBook-Air.local>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] > On May 27, 2023, at 12:35 PM, Peter Holm <pho@FreeBSD.org> wrote: > > On Sat, May 27, 2023 at 11:10:23AM -0700, Enji Cooper wrote: >> >>> On May 27, 2023, at 1:35 AM, Peter Holm <pho@FreeBSD.org> wrote: >>> >>> The branch main has been updated by pho: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/?id=acfb06062a6862f7c823242243e68f7bcaf29999 >>> >>> commit acfb06062a6862f7c823242243e68f7bcaf29999 >>> Author: Peter Holm <pho@FreeBSD.org> >>> AuthorDate: 2023-05-27 08:31:00 +0000 >>> Commit: Peter Holm <pho@FreeBSD.org> >>> CommitDate: 2023-05-27 08:31:00 +0000 >>> >>> stress2: Fix warnings >> >> It seems like `n` could be removed in all of the sample programs. >> Cheers, >> -Enji >> > > Both 'n' and 'm' are used if DEBUG is defined. > > [pho@mercat1 /usr/src/tools/test/stress2/misc]$ ./reaper2.sh > n = 19779 out of 56033 > n = 20099 out of 56319 > n = 20121 out of 56406 I see. Maybe the variables should only be declared/defined in the DEBUG case? Right now __unused kind of sends the wrong message to the developer and to the compiler (potentially). Cheers, -Enji [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEtvtxN6kOllEF3nmX5JFNMZeDGN4FAmRybjsACgkQ5JFNMZeD GN6A4A/8CenQCNZ/OD8t3LOmZi+roaXqzkz6L+7MSOgnQB6VTR9Yyronu3HM3swj bqMJXd0Us9wFvcCbVZyNuN2D92dju6s2fx6GjrgvUwN29XkKU7f711maxeG/r7wS y/aZSHwOQqksbNHtpKhcHs6KQO2zeDfDIIxBMRdnDeDqBRzvBQoo3WHa2eBuojIb AkA2ig27tA3a11Vh5kHjJYs/KdOs/3HipFmrHOfaFE2MN8P4hO8bl6BhNs/n+Tc7 oxVg1nLE7zcK3F2mdeob4uDuaPSs4aEfLzcXkDOtFKoeB5pufalk/H7+RMCm3trZ RkyBDbgqybQz88nXXDw+554tRsukR3GZbgTt2NEf/zv+lM05vVE/OYfQBJtnHMWY b3huUgGowqJBeEjYY+5TQpA7u35QUwBDtsVdF5vtkcPjHnSAT7fPOXzM62A7biEK van0VhfELp4dBU7RXyihkpkWN7ivYNYt8U8144eOK+1DdxiT3GFqgrA03A0sF3p8 i031UmCAFHMT1PAF71JGirbm3Vb8q6MtYZAaotKNGv9ibksliET283rxE2n1Qcjf aCrUrXmI1vGHJ05n7NDb6BDy4aYuZG7Hb8lHfBmwYwJn4WOdoO0xPGciKLep6OGR m8urjvogqJyn4LhGBLrEXLhwLEgKK5iRN9vcn6aT8gapUEseEkI= =lXGo -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?605A888E-8907-4B20-8922-86511E383377>