Date: Sun, 10 Dec 2017 21:55:25 -0800 From: Kevin Oberman <rkoberman@gmail.com> To: "Greg 'groggy' Lehey" <grog@freebsd.org> Cc: Walter Schwarzenfeld <w.schwarzenfeld@utanet.at>, FreeBSD Ports ML <freebsd-ports@freebsd.org> Subject: Re: make reinstall does not work Message-ID: <CAN6yY1uas3MEXucW9Sum9aGnQzH5PGsiCNmU59C8G1mVfr%2BF4g@mail.gmail.com> In-Reply-To: <20171210224216.GN78437@eureka.lemis.com> References: <CAN6yY1vhuZOQcGVRouF5__pJyzPnZtbA%2BVrCdMTurYqyzmQW7g@mail.gmail.com> <eb5f3046-1c55-6890-761b-bc339848a075@utanet.at> <20171210224216.GN78437@eureka.lemis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Dec 10, 2017 at 2:42 PM, Greg 'groggy' Lehey <grog@freebsd.org> wrote: > On Sunday, 10 December 2017 at 20:32:38 +0100, Walter Schwarzenfeld wrote: > > Look at the link in Shawn Webb's post: > > > > bapt (Baptisse Daroussin) wrote > > > > *bapt <https://github.com/bapt>; * replied Nov 16, 2017 > > <https://github.com/freebsd/pkg/commit/ > 7991c49665419916210ad589d4a85fd2a7f58b37#commitcomment-25649084> > > You should have quoted that in your reply. And are we really now > using github as the primary repository? > > > because it should have always been like that, the real > > reinstallation was make deinstall reinstall, the fact one needs not > > to run deinstall first was a bug introduced very very long ago > > This doesn't make much sense to me. If I do a make deinstall, the > package is gone. Then all I need is a make install, and that does, > indeed, work. make reinstall by itself also used to work. I'll go > with the others and assume that this was a transient bug. > > Greg > -- > Sent from my desktop computer. > Finger grog@FreeBSD.org for PGP public key. > See complete headers for address and phone numbers. > This message is digitally signed. If your Microsoft mail program > reports problems, please read http://lemis.com/broken-MUA > interesting! I know that the procedure back in the pre-portupgrade days was make, make deinstall, make reinstall, make clean. I looked at the code back then and reinstall did different things to the old, pre-pkgng, ports DB than install. I don't recall the details, but they are probably in the ancient parts of the svn repo. That said, the current version of reinstall clearly could failed in an ugly way as it does not ever uninstall the old port, just installs the new one which could easily leave any files that is no longer a part of the port in the $LOCALDIR. Not good! What is needed is to make the reinstall target properly handle the error of reinstalling a port that is still installed. "Error 70" is really not a good message,
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAN6yY1uas3MEXucW9Sum9aGnQzH5PGsiCNmU59C8G1mVfr%2BF4g>