Date: Fri, 25 Apr 2003 08:50:30 -0700 From: "Sam Leffler" <sam@errno.com> To: "Nate Lawson" <nate@root.org>, <cvs-all@FreeBSD.org>, <cvs-src@FreeBSD.org>, <src-committers@FreeBSD.org> Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h Message-ID: <06fe01c30b42$66705210$52557f42@errno.com> References: <Pine.BSF.4.21.0304250204280.64445-100000@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> For developers, note that the locking in the code path only protects the
> various fxp routines (fxp_start, fxp_intr, fxp_tick, ...) and is not
> intended to serialize access to ANY external structures. This is how it
> should be. Please do not copy the exact approach taken here for a little
> while until ifnet locking is finished as there may need to be some changes
> made to this model.
This doesn't make much sense to me. I've locked numerous chunks of code and
used a totally different approach: synchronize access to data structures,
not code paths. Perhaps you and Jeffrey Hsu need to have a private
discussion...
Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?06fe01c30b42$66705210$52557f42>