Date: Fri, 3 Feb 2023 16:42:25 +0000 From: Brooks Davis <brooks@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: freebsd-git <freebsd-git@freebsd.org> Subject: Re: Proposed Github Pull Request Policy Message-ID: <Y905cVvlrQ5YPqgA@spindle.one-eyed-alien.net> In-Reply-To: <CANCZdfq_=pDon8LmhjV%2BWyPsGcuG1hp3LrfxXe9mJ51J0P2iqg@mail.gmail.com> References: <CANCZdfq_=pDon8LmhjV%2BWyPsGcuG1hp3LrfxXe9mJ51J0P2iqg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 02, 2023 at 07:12:29PM -0700, Warner Losh wrote: > Geetngs, >=20 > I'd like to put some parameters around the pull requests on github. To th= at > end, I'd like us to consider the following policy: This seems like a good start. > Pull requests shouldn't expand in scope in response to feedback: If the > feedback suggests a new series of changes, please create a new pull > requests. I think I'd prefer: "Pull requests shouldn't expand in scope once created:...". Some direction on using rebase and forced push when addressing feedback is probably also in order. If I'm taking a few minutes to look at a PR that caught my eye I don't want to wade through a bunch of fixups. -- Brooks
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Y905cVvlrQ5YPqgA>