Date: Thu, 27 Oct 2005 21:16:17 +0000 (UTC) From: John Baldwin <jhb@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/txp if_txp.c if_txpreg.h Message-ID: <200510272116.j9RLGHdW035755@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
jhb 2005-10-27 21:16:17 UTC
FreeBSD src repository
Modified files:
sys/dev/txp if_txp.c if_txpreg.h
Log:
- Add locking and mark MPSAFE. The driver had a mutex in the softc and
even initialized it, but it never used it.
- Use callout_*() to manage the callout.
- Use m_devget() to copy data out of the rx buffers rather than doing it
all by hand.
- Use m_getcl() to allocate mbuf clusters rather than doing it all by hand.
- Don't free the software descriptor for a rx ring entry if we can't
allocate an mbuf cluster for it. We left a dangling pointer and never
reallocated the entry anyway. OpenBSD's code (from which this was
derived) has the same bug.
Tested by: NO ONE (despite repeated requests)
Reviewed by: wpaul (5)
Revision Changes Path
1.37 +81 -61 src/sys/dev/txp/if_txp.c
1.6 +5 -1 src/sys/dev/txp/if_txpreg.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200510272116.j9RLGHdW035755>