Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 25 Oct 2002 11:46:15 +0100
From:      Ceri Davies <setantae@submonkey.net>
To:        Adam Weinberger <adamw@FreeBSD.ORG>
Cc:        Tom Hukins <tom@FreeBSD.ORG>, freebsd-doc@FreeBSD.ORG
Subject:   Re: docs/44396: Section 15.1 of the Porter's Handbook is no longer applicable
Message-ID:  <20021025104615.GB7415@submonkey.net>
In-Reply-To: <20021025103619.GM70503@vectors.cx>
References:  <200210242100.g9OL0AGV025120@freefall.freebsd.org> <20021025103619.GM70503@vectors.cx>

next in thread | previous in thread | raw e-mail | index | archive | help

On Fri, Oct 25, 2002 at 03:36:19AM -0700, Adam Weinberger wrote:
> >> (10.24.2002 @ 1400 PST): Tom Hukins said, in 1.1K: <<
> >  > The section could stay around, and just become a Don't... "Don't strip
> >  > unless you have to."
> >  
> >  That makes sense.
> 
> What are your thoughts on this:
> 
> ===================================================================
> RCS file:
> /home/ncvs/doc/en_US.ISO8859-1/books/porters-handbook/book.sgml,v
> retrieving revision 1.248
> diff -u -r1.248 book.sgml
> --- doc/en_US.ISO8859-1/books/porters-handbook/book.sgml        8 Oct
> 2002 04:52:43 -00001.248
> +++ doc/en_US.ISO8859-1/books/porters-handbook/book.sgml        25 Oct
> 2002 10:32:23 -0000

Can you tell mutt not to wrap and post this again?  It's hard to read.

> @@ -3938,19 +3938,27 @@
>          doing.</para>
>  
>        <sect1>
> -        <title>Strip Binaries</title>
> +        <title>Stripping Binaries</title>
>  
> -        <para>Do strip binaries.  If the original source already strips
>          the
> -          binaries, fine; otherwise you should add a
> -          <literal>post-install</literal> rule to it yourself.  Here is
>            an
> -          example:</para>
> +               <para>Don't strip binaries manually unless you have to. All binaries

This indentation doesn't look consistent with the stuff you've removed.
That might be down to the line wrap again though.

Also, you have contraction in there : "Don't".
These are generally to be avoided, so could you change that to "Do not" ?

> +               should be stripped, but the <maketarget>INSTALL_PROGRAM</maketarget>
> +               macro will install and strip a bnary at the same time (see the next

s/bnary/binary/

> +               <para>If you need to strip a file, but don't wish to use the

s/don't/do not/ again.

The actual content looks really good though, thanks again!

Ceri
-- 
you can't see when light's so strong
you can't see when light is gone

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-doc" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021025104615.GB7415>