Date: Tue, 19 Nov 2013 19:00:01 GMT From: Xin Li <delphij@delphij.net> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/184092: zfs zvol devices are not appearing till after reimport of pool Message-ID: <201311191900.rAJJ01S1085369@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/184092; it has been noted by GNATS.
From: Xin Li <delphij@delphij.net>
To: Christopher Harrison <harrison@glsan.com>,
freebsd-gnats-submit@FreeBSD.org
Cc: Andriy Gapon <avg@freebsd.org>
Subject: Re: kern/184092: zfs zvol devices are not appearing till after reimport
of pool
Date: Tue, 19 Nov 2013 10:50:34 -0800
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
I think Andriy (cc'ed) have fixed a similar issue. A quick glance at
the code suggests maybe we can use something like this:
Index: sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c
===================================================================
- --- sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c
(revision 258350)
+++ sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c
(working copy)
@@ -3298,6 +3298,10 @@ zfs_ioc_clone(const char *fsname, nvlist_t *innvl,
if (error != 0)
(void) dsl_destroy_head(fsname);
}
+#ifdef __FreeBSD__
+ if (error == 0)
+ zvol_create_minors(fsname);
+#endif
return (error);
}
Can you confirm if this helps?
(I think we should use a better way to trigger zvol_create_minor,
maybe via a devfs lookup hook?)
Cheers,
-----BEGIN PGP SIGNATURE-----
iQIcBAEBCgAGBQJSi7L6AAoJEJW2GBstM+nsU7IQAKJhuls5BEXXsvp8SsoJDZ1x
7SK4BP27cIF++hqzf4DVyP5OJEXFivFBgmbbdcS2q91X4ZR7kwdp/c7PWLArrtLO
uQkQaeFpr5xvZsro6n58zVqjFc6ItaEZ0RWsv82Rqx9lVX8INb3Z/AneM2HXVXkX
GDPTCf17bsxcgsxeCXgirpYYO4bOnUlTCNNmBSR62BNvQRNHwrTO+wVRVLGkZ4JK
/y0GtiE2P1xhGq24XNswGqlmZPwBZHvqrvMXM1BjAdW2/kKuzWQ2HA9nflSGFK5k
V502qe+fZXK4p227/9To1XfNIDC2GnONfvYOjqJigwjvd+2zENVxyLphHowfQpkw
qWOgQ7b8nHc5GzjkWRJIJVm1JJHSHfAyH3VRwHBkEOGv0qs/ScM3x9mjaeqSb5Uu
cIAF2vMt9gDfvgsV1fL0y33qOGFMFqPW7E0oOPGHrDMRQPUsGAeItUWCppbxmnVD
HkCbPxYiH3EoFXULT8kX5gthRpbl1IveEluGGFITPxYsj1XmUvmQPBSkJPauoTvZ
0Aoe306mfuad8gmCBxpSCqTs9cvQrzeOvfc3bMKSLmSCbZ7SfnwG1EVGUMiX1DI9
1ugyRXHPlCZ/59HsEDym+Jlz/cqijo+dFykgjllwiwQtgzQSAhlaiyXjVZIxhfKL
EgIpjuU+stDV10DsEwow
=jwi6
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201311191900.rAJJ01S1085369>