Date: Sun, 10 Jul 2005 16:57:52 +0930 From: "Wilkinson, Alex" <alex.wilkinson@dsto.defence.gov.au> To: Poul-Henning Kamp <phk@haven.freebsd.dk> Cc: freebsd-current@freebsd.org, current@freebsd.org Subject: Re: [TEST/REVIEW] boot0cfg/fdisk issue fix Message-ID: <20050710072752.GA39156@squash.dsto.defence.gov.au> In-Reply-To: <20514.1120916772@phk.freebsd.dk> References: <200507090932.12973.jhb@FreeBSD.org> <20514.1120916772@phk.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
0n Sat, Jul 09, 2005 at 03:46:12PM +0200, Poul-Henning Kamp wrote:
>In message <200507090932.12973.jhb@FreeBSD.org>, John Baldwin writes:
>>On Tuesday 05 July 2005 04:44 pm, Poul-Henning Kamp wrote:
>>> This is an attempt to fix an boot0cfg/fdisk issue which I have
>>> overlooked.
>>>
>>> The patch adds a g_ctl method to geom_mbr and makes boot0cfg and
>>> fdisk use it to modify the MBR if possible.
>>>
>>> Please test and report ASAP in order to get this solution into
>>> RELENG_6
>>
>>Only thing I noted is that it seems that you changed boot0 to always only
>>write 512 bytes which means it will break trying to use boot0cfg to install
>>boot0ext (which is 2 sectors). Perhaps you should check the filesize of the
>>boot you are writing and if it's > 512, write the other data with a write(2)
>>after the g_ctl()? Perhaps I don't see quite understand what your g_ctl() is
>>doing though.
>
>Damn, didn't think of that...
what is boot0ext ?
- aW
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050710072752.GA39156>