Date: Sun, 04 Nov 2007 23:34:48 +0300 From: Yuri Pankov <yuri.pankov@gmail.com> To: Joe Marcus Clarke <marcus@marcuscom.com> Cc: gnome@freebsd.org Subject: Re: [PATCH] databases/evolution-data-server: Fix segfault on new installs Message-ID: <1194208488.95123.1.camel@darklight.org.ru> In-Reply-To: <1194206856.3161.5.camel@shumai.marcuscom.com> References: <200711031707.lA3H7KSI002054@bbeng-laptop.acs.internap.com> <1194206264.1265.2.camel@darklight.org.ru> <1194206856.3161.5.camel@shumai.marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 2007-11-04 at 15:07 -0500, Joe Marcus Clarke wrote:
> On Sun, 2007-11-04 at 22:57 +0300, Yuri Pankov wrote:
> > On Sat, 2007-11-03 at 13:07 -0400, Robert C. Noland III wrote:
> > > >Submitter-Id: current-users
> > > >Originator: Robert C. Noland III
> > > >Organization:
> > > >Confidential: no
> > > >Synopsis: [PATCH] databases/evolution-data-server: Fix segfault on new installs
> > > >Severity: non-critical
> > > >Priority: low
> > > >Category: ports
> > > >Class: change-request
> > > >Release: FreeBSD 8.0-CURRENT i386
> > > >Environment:
> > > System: FreeBSD bbeng-laptop.acs.internap.com 8.0-CURRENT FreeBSD 8.0-CURRENT #92: Mon Oct 15 12:26:58 EDT 2007
> > > >Description:
> > > Evolution will segfault while trying to collect timezone data on a new install.
> > > Off by one test in timezone parsing.
> > >
> > > Port maintainer (gnome@FreeBSD.org) is cc'd.
> > >
> > > Generated with FreeBSD Port Tools 0.77
> > > >How-To-Repeat:
> > > >Fix:
> > >
> > > --- evolution-data-server-1.12.1_2.patch begins here ---
> > > Index: Makefile
> > > ===================================================================
> > > RCS file: /home/ncvs/ports/databases/evolution-data-server/Makefile,v
> > > retrieving revision 1.41
> > > diff -u -r1.41 Makefile
> > > --- Makefile 24 Oct 2007 23:35:16 -0000 1.41
> > > +++ Makefile 3 Nov 2007 17:04:29 -0000
> > > @@ -8,7 +8,7 @@
> > >
> > > PORTNAME= evolution-data-server
> > > PORTVERSION= 1.12.1
> > > -PORTREVISION= 1
> > > +PORTREVISION= 2
> > > CATEGORIES= databases gnome
> > > MASTER_SITES= ${MASTER_SITE_GNOME}
> > > MASTER_SITE_SUBDIR= sources/${PORTNAME}/${PORTVERSION:C/^([0-9]+\.[0-9]+).*/\1/}
> > > Index: files/patch-calendar_libical_src_libical_icaltz-util.c
> > > ===================================================================
> > > RCS file: /home/ncvs/ports/databases/evolution-data-server/files/patch-calendar_libical_src_libical_icaltz-util.c,v
> > > retrieving revision 1.1
> > > diff -u -r1.1 patch-calendar_libical_src_libical_icaltz-util.c
> > > --- files/patch-calendar_libical_src_libical_icaltz-util.c 24 Oct 2007 23:35:17 -0000 1.1
> > > +++ files/patch-calendar_libical_src_libical_icaltz-util.c 3 Nov 2007 17:04:29 -0000
> > > @@ -1,5 +1,5 @@
> > > ---- calendar/libical/src/libical/icaltz-util.c.orig 2007-08-24 02:48:28.000000000 -0400
> > > -+++ calendar/libical/src/libical/icaltz-util.c 2007-08-27 16:23:59.000000000 -0400
> > > +--- calendar/libical/src/libical/icaltz-util.c.orig 2007-10-12 02:31:10.000000000 -0400
> > > ++++ calendar/libical/src/libical/icaltz-util.c 2007-11-03 12:22:24.000000000 -0400
> > > @@ -23,6 +23,15 @@
> > > #include <string.h>
> > > #if defined(sun) && defined(__SVR4)
> > > @@ -16,3 +16,12 @@
> > > #else
> > > #include <byteswap.h>
> > > #include <endian.h>
> > > +@@ -148,7 +157,7 @@
> > > + idx = trans_idx [i];
> > > + types [idx].isdst ? (*dstidx = i) : (*stdidx = i);
> > > +
> > > +- if (i >= num_trans)
> > > ++ if (i >= num_trans - 1)
> > > + i--;
> > > + else
> > > + i++;
> > > --- evolution-data-server-1.12.1_2.patch ends here ---
> >
> > It looks very similar to the crash I've been experiencing -
> > http://bugzilla.gnome.org/show_bug.cgi?id=492426
> > If it's indeed the same problem, could you please submit a followup
> > there?
>
> Please test his patch, and see if it fixes the bug. If so, I will
> commit before the release.
>
> Joe
>
Of course... Yes, it does fix the bug (I've created new account to test
- Evolution started normally, didn't start at all without the patch).
Thanks,
Yuri
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1194208488.95123.1.camel>