Date: Sat, 31 Oct 2020 15:25:49 -0500 From: "Brandon Bergren" <bdragon@FreeBSD.org> To: "Mateusz Guzik" <mjguzik@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: =?UTF-8?Q?Re:_svn_commit:_r367229_-_in_head/sys/contrib/openzfs:_include?= =?UTF-8?Q?/sys/zstd_module/zstd?= Message-ID: <d5618cc3-3b0c-4c39-909e-863bd2f30de3@www.fastmail.com> In-Reply-To: <CAGudoHFXAiobCwFgiNUj9UNRShNO1FctjsfS5w8xaWc%2B--d-gg@mail.gmail.com> References: <202010311907.09VJ7WcY036325@repo.freebsd.org> <7b9e157c-9b8e-4a0e-b3f6-38edbfebf005@www.fastmail.com> <CAGudoHFXAiobCwFgiNUj9UNRShNO1FctjsfS5w8xaWc%2B--d-gg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Actually, looking at it again, it looks like the spl header is doing it wrong and not providing a fallback for atomic_sub_64, it's just defining it to atomic_subtract_64 and assuming that exists. On Sat, Oct 31, 2020, at 3:23 PM, Mateusz Guzik wrote: > Yep, jenkins told me. Working on it. > > On 10/31/20, Brandon Bergren <bdragon@freebsd.org> wrote: > > This doesn't compile on platforms such as powerpc without pulling in the > > opensolaris atomics header from the spl that does locking emulation of 64 > > bit atomics, as platforms that don't have native 64 bit atomics do not > > provide them in the system header.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d5618cc3-3b0c-4c39-909e-863bd2f30de3>