Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 21 Jun 2016 13:33:20 -0400
From:      Paul Mather <paul@gromit.dlib.vt.edu>
To:        Keith White <kwhite@site.uottawa.ca>
Cc:        Luiz Otavio O Souza <loos.br@gmail.com>, "freebsd-arm@freebsd.org" <freebsd-arm@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org>, Maxim Sobolev <sobomax@sippysoft.com>
Subject:   Re: BBB (cpsw(4)) seems to be broken in the latest 11-current
Message-ID:  <DB254FD5-E729-4E1B-881D-ABB61C0FED39@gromit.dlib.vt.edu>
In-Reply-To: <alpine.BSF.2.20.1606201832030.52002@localhost.my.domain>
References:  <CAH7qZfsMiUSCTG827ysO89o9nH9WAKu4w%2BiZPZ-UKKVa6T2pcA@mail.gmail.com> <CAFHCsPWUFDiM%2BQh6EkNKPdbm0BrqtgStdzig4WyFmj8L31qN%2Bg@mail.gmail.com> <CAH7qZftdjhrp_m440BPHeArSnV-QQmghm4UyMJ3qro75NMGPQA@mail.gmail.com> <83A18C0E-FA89-4009-A8D5-3185FB27A688@netgate.com> <CAH7qZfvRB4y=GP9yjCAjjBy2h3pHTifdm0t%2BTTVFONQNPe9=8w@mail.gmail.com> <CAH7qZfvAh-dSRYM7G1BkpgMZc3zkeSDakj7LOO=s2JF%2BUy=eUw@mail.gmail.com> <CAJ8CS7qEAjhON6vBL2%2Bh5u=EOK20jnSFzRV1%2BsF3a-GUhLjHoQ@mail.gmail.com> <alpine.BSF.2.20.1606201832030.52002@localhost.my.domain>

next in thread | previous in thread | raw e-mail | index | archive | help
On Jun 20, 2016, at 6:33 PM, Keith White <kwhite@site.uottawa.ca> wrote:

> On Mon, 20 Jun 2016, Luiz Otavio O Souza wrote:
>=20
>> On Sun, Jun 19, 2016 at 1:11 AM, Maxim Sobolev wrote:
>>> Jim, some update from here. Running r283287 of the driver, I still =
see the
>>> same "watchdog timeout" messages, but they do not lead to the =
interface
>>> lockout. The traffic resumes momentarily. Which is probably why I =
never paid
>>> much attention to those warnings before. Therefore, I suspect that =
the new
>>> MAC code does not deal with watchdog-triggered interface reset as =
good as
>>> the old code. Does it give you any ideas about what could be wrong =
there by
>>> any chance?
>>=20
>>=20
>> Hi Maxim,
>>=20
>> My recent changes contributed somehow to expose the bug more =
frequently.
>>=20
>> There was a condition in tx packet reclamation where we aren't
>> restarting the tx queue in one of the possible stall conditions.
>>=20
>> Please try the attached patch and let me know if it works for you.
>>=20
>> Luiz
>=20
> Your patch fixes the problem for me.  Thanks!
>=20
> FreeBSD beaglebone 11.0-ALPHA4 FreeBSD 11.0-ALPHA4 #0 r302028M: Mon =
Jun 20 18:19:55 EDT 2016     =
kwhite@freebsd11:/usr/obj/arm.armv6/usr/src/sys/BEAGLEBONE-LOCAL  arm =
armv6
>=20
> ...keith


The patch also fixes the problem for me.

FreeBSD beaglebone 11.0-ALPHA4 FreeBSD 11.0-ALPHA4 #2 r302030M: Tue Jun =
21 10:20:59 EDT 2016     =
pmather@beaglebone:/usr/obj/usr/src/sys/BEAGLEBONE-NO_WITNESS  arm


Cheers,

Paul.




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DB254FD5-E729-4E1B-881D-ABB61C0FED39>