Date: Wed, 25 Aug 2004 11:17:30 -0700 From: "David O'Brien" <obrien@freebsd.org> To: Sean McNeil <sean@mcneil.com> Cc: current@freebsd.org Subject: Re: bsdtar core dumps Message-ID: <20040825181730.GJ53710@dragon.nuxi.com> In-Reply-To: <1093385848.84723.2.camel@server.mcneil.com> References: <1092777586.92327.9.camel@server.mcneil.com> <1093369220.10362.6.camel@server.mcneil.com> <20040824200225.V517@beagle.kn.op.dlr.de> <1093371600.10464.23.camel@server.mcneil.com> <20040824205417.L517@beagle.kn.op.dlr.de> <1093377802.43728.11.camel@server.mcneil.com> <1093385848.84723.2.camel@server.mcneil.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Aug 24, 2004 at 03:17:28PM -0700, Sean McNeil wrote: > > > SM>> You cannot use a va_list twice. As soon as someone call > > > va_arg() on the SM>> ap all the aps in the calling functions get > > > invalid. The only thing that SM>> can and must be done is that the > > > function that did the va_start() must SM>> call va_end. ... > I missed one in vfwprintf.c. I needs a va_end(orgap) just like above. > > Also, I've searched all of src and found one additional place that there > is a va_copy without a va_end. > > contrib/gnu-sort/lib/version-etc.c > > All other uses appear to be properly matched. Can you please make a new, complete patch? I'll commit it ASAP. -- -- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040825181730.GJ53710>