Date: Sat, 11 Aug 2001 13:47:29 -0700 (PDT) From: Matt Dillon <dillon@earth.backplane.com> To: Mike Barcroft <mike@FreeBSD.org> Cc: Josef Karthauser <joe@tao.org.uk>, Eivind Eklund <eivind@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: CVS patch implements update -T (was Re: Remote CVS/Template) Message-ID: <200108112047.f7BKlT419906@earth.backplane.com> References: <3B4F1FCD.7F2D4842@FreeBSD.org> <20010713120140Q.jkh@osd.bsdi.com> <20010713211017.A57434@heechee.tobez.org> <20010713123241X.jkh@osd.bsdi.com> <200107132214.f6DMET571067@earth.backplane.com> <20010715143503.A10888@FreeBSD.org> <20010810133132.G624@tao.org.uk> <200108111945.f7BJjIo19532@earth.backplane.com> <20010811170257.B23231@coffee.q9media.com>
next in thread | previous in thread | raw e-mail | index | archive | help
:Is there a reason why you aren't checking the result of asprintf(3)
:for memory allocation errors? I believe your other patch suffers
:from a similar problem with strdup(3). Other than that, the changes
:look good.
:
:BTW, great article on DaemonNews this month.
:
:Best regards,
:Mike Barcroft
I suppose I could add a check. I usually have a 'safe_asprintf' routine
that I use for my own work. I NULL-out the pointers before-hand
so the worse that will happen is that the program will seg fault.
-Matt
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200108112047.f7BKlT419906>