Date: Fri, 29 Nov 2019 03:51:01 +0000 (UTC) From: Kyle Evans <kevans@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r355205 - head/sys/dev/snp Message-ID: <201911290351.xAT3p1Tq024949@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: kevans Date: Fri Nov 29 03:51:01 2019 New Revision: 355205 URL: https://svnweb.freebsd.org/changeset/base/355205 Log: snp: don't reference tp->t_mtx directly This is the only part of snp(4) that pokes around in struct tty directly; replace it with the tty_getlock accessor to avoid struct tty internals. Modified: head/sys/dev/snp/snp.c Modified: head/sys/dev/snp/snp.c ============================================================================== --- head/sys/dev/snp/snp.c Fri Nov 29 03:31:47 2019 (r355204) +++ head/sys/dev/snp/snp.c Fri Nov 29 03:51:01 2019 (r355205) @@ -178,7 +178,7 @@ snp_read(struct cdev *dev, struct uio *uio, int flag) error = EWOULDBLOCK; break; } - error = cv_wait_sig(&ss->snp_outwait, tp->t_mtx); + error = cv_wait_sig(&ss->snp_outwait, tty_getlock(tp)); if (error != 0) break; if (tty_gone(tp)) {
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201911290351.xAT3p1Tq024949>