Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 21 Oct 2015 01:45:18 +0000 (UTC)
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-9@freebsd.org
Subject:   svn commit: r289673 - stable/9/sys/compat/linux
Message-ID:  <201510210145.t9L1jILm069737@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: bdrewery
Date: Wed Oct 21 01:45:18 2015
New Revision: 289673
URL: https://svnweb.freebsd.org/changeset/base/289673

Log:
  MFC r288994:
  
    Remove redundant RFFPWAIT/vfork(2) handling in Linux fork(2) and clone(2)
    wrappers.

Modified:
  stable/9/sys/compat/linux/linux_fork.c
Directory Properties:
  stable/9/sys/   (props changed)

Modified: stable/9/sys/compat/linux/linux_fork.c
==============================================================================
--- stable/9/sys/compat/linux/linux_fork.c	Wed Oct 21 01:41:22 2015	(r289672)
+++ stable/9/sys/compat/linux/linux_fork.c	Wed Oct 21 01:45:18 2015	(r289673)
@@ -110,9 +110,8 @@ linux_vfork(struct thread *td, struct li
 		printf(ARGS(vfork, ""));
 #endif
 
-	/* Exclude RFPPWAIT */
-	if ((error = fork1(td, RFFDG | RFPROC | RFMEM | RFSTOPPED, 0, &p2,
-	    NULL, 0)) != 0)
+	if ((error = fork1(td, RFFDG | RFPROC | RFMEM | RFPPWAIT | RFSTOPPED,
+	    0, &p2, NULL, 0)) != 0)
 		return (error);
 
    	td->td_retval[0] = p2->p_pid;
@@ -121,10 +120,6 @@ linux_vfork(struct thread *td, struct li
 	if (error)
 		return (error);
 
-	PROC_LOCK(p2);
-	p2->p_flag |= P_PPWAIT;
-	PROC_UNLOCK(p2);
-
 	td2 = FIRST_THREAD_IN_PROC(p2);
 
 	/*
@@ -135,12 +130,6 @@ linux_vfork(struct thread *td, struct li
 	sched_add(td2, SRQ_BORING);
 	thread_unlock(td2);
 
-	/* wait for the children to exit, ie. emulate vfork */
-	PROC_LOCK(p2);
-	while (p2->p_flag & P_PPWAIT)
-		cv_wait(&p2->p_pwait, &p2->p_mtx);
-	PROC_UNLOCK(p2);
-
 	return (0);
 }
 
@@ -202,6 +191,9 @@ linux_clone(struct thread *td, struct li
 		if (args->parent_tidptr == NULL)
 			return (EINVAL);
 
+	if (args->flags & LINUX_CLONE_VFORK)
+		ff |= RFPPWAIT;
+
 	error = fork1(td, ff, 0, &p2, NULL, 0);
 	if (error)
 		return (error);
@@ -270,12 +262,6 @@ linux_clone(struct thread *td, struct li
 		    "stack %p sig = %d"), (int)p2->p_pid, args->stack,
 		    exit_signal);
 #endif
-	if (args->flags & LINUX_CLONE_VFORK) {
-	   	PROC_LOCK(p2);
-	   	p2->p_flag |= P_PPWAIT;
-	   	PROC_UNLOCK(p2);
-	}
-
 	/*
 	 * Make this runnable after we are finished with it.
 	 */
@@ -287,13 +273,5 @@ linux_clone(struct thread *td, struct li
 	td->td_retval[0] = p2->p_pid;
 	td->td_retval[1] = 0;
 
-	if (args->flags & LINUX_CLONE_VFORK) {
-		/* wait for the children to exit, ie. emulate vfork */
-		PROC_LOCK(p2);
-		while (p2->p_flag & P_PPWAIT)
-			cv_wait(&p2->p_pwait, &p2->p_mtx);
-		PROC_UNLOCK(p2);
-	}
-
 	return (0);
 }

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201510210145.t9L1jILm069737>