Date: Sun, 25 May 2014 06:24:02 GMT From: Trevor Roydhouse <fbsdbugs2@sentry.org> To: freebsd-gnats-submit@FreeBSD.org Subject: kern/190195: Missing asmc support for Macmini 3,1 Message-ID: <201405250624.s4P6O2uW099413@cgiserv.freebsd.org> Resent-Message-ID: <201405250630.s4P6U0GP053908@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 190195
>Category: kern
>Synopsis: Missing asmc support for Macmini 3,1
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun May 25 06:30:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: Trevor Roydhouse
>Release: 9.3-PRERELEASE
>Organization:
>Environment:
FreeBSD shadow.sentry.org 9.3-PRERELEASE FreeBSD 9.3-PRERELEASE #12 r266632: Sun May 25 13:32:10 EST 2014 root@shadow.sentry.org:/usr/obj/usr/src/sys/MACMINI i386
>Description:
The asmc module lacks details for the Macmini 3,1 hardware version.
>How-To-Repeat:
kldload supplied asmc.ko
>Fix:
See attached patches for asmc.c and asmcvar.h which have been running successfully on my system since FreeBSD 9.1-STABLE.
Patch attached with submission follows:
asmc.c
208a209,217
> /* The Mac Mini 3,1 has no SMS */
> {
> "Macmini3,1", "Apple SMC Mac Mini 3,1",
> NULL, NULL, NULL,
> ASMC_FAN_FUNCS,
> NULL, NULL, NULL,
> ASMC_MM31_TEMPS, ASMC_MM31_TEMPNAMES, ASMC_MM31_TEMPDESCS
> },
>
asmcvar.h
182a183,201
> #define ASMC_MM31_TEMPS { "TC0D", "TC0H", \
> "TC0P", "TH0P", \
> "TN0D", "TN0P", \
> "TW0P", NULL }
>
> #define ASMC_MM31_TEMPNAMES { "cpu0_die", "cpu0_heatsink", \
> "cpu0_proximity", "hdd_bay", \
> "northbridge_die", \
> "northbridge_proximity", \
> "wireless_module", }
>
> #define ASMC_MM31_TEMPDESCS { "CPU0 Die Core Temperature", \
> "CPU0 Heatsink Temperature", \
> "CPU0 Proximity Temperature", \
> "HDD Bay Temperature", \
> "Northbridge Die Core Temperature", \
> "Northbridge Proximity Temperature", \
> "Wireless Module Temperature", }
>
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201405250624.s4P6O2uW099413>