Date: Sat, 13 Jun 2015 21:24:34 +0300 From: Andrey Chernov <ache@freebsd.org> To: Julian Elischer <julian@freebsd.org>, Steve Kargl <sgk@troutmask.apl.washington.edu>, Alexander Kabaev <kabaev@gmail.com> Cc: Marcel Moolenaar <marcel@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r284198 - head/bin/ls Message-ID: <557C7562.4000809@freebsd.org> In-Reply-To: <557C3D9D.5050905@freebsd.org> References: <201506100127.t5A1RdX6051959@svn.freebsd.org> <20150612204309.11dd3391@kan> <20150613024916.GA98218@troutmask.apl.washington.edu> <557C3D9D.5050905@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 13.06.2015 17:26, Julian Elischer wrote: > On 6/13/15 10:49 AM, Steve Kargl wrote: >> On Fri, Jun 12, 2015 at 08:43:09PM -0400, Alexander Kabaev wrote: >>> On Wed, 10 Jun 2015 01:27:39 +0000 (UTC) >>> Marcel Moolenaar <marcel@FreeBSD.org> wrote: >>> >>>> Author: marcel >>>> Date: Wed Jun 10 01:27:38 2015 >>>> New Revision: 284198 >>>> URL: https://svnweb.freebsd.org/changeset/base/284198 >>>> >>>> Log: >>>> Convert ls(1) to use libxo(3). >>>> Obtained from: Phil Shafer <phil@juniper.net> >>>> Sponsored by: Juniper Networks, Inc. >>>> >>> <SKIP> >>> >>> This broke all code that pipes output of the ls command to pipeline, >>> such as 'ls | wc -l'. ls never exits and never output anything. Is >>> there any purpose to libxo other than breaking stuff, which it achieves >>> so splendidly? >>> >> -1 for libxo, which also makes code almost unreadable. > +1 of the -1 > > my personal vote is to revert all libxo changes and banish it from > /usr/src. I already express my opinion in another thread, so just repeat it here. When libxo starts to break things at very early stage, I perceive the rest of the way to hell. "Proper way to do this thing is to back out all changes and write completely separate templates-based parser - xml/json/etc. writer." If somebody love libxo code, use it in that parser/writer. -- http://ache.vniz.net/ -- http://vniz.net/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?557C7562.4000809>