Date: Tue, 4 Jun 2013 23:29:17 +0200 From: Jilles Tjoelker <jilles@stack.nl> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: Konstantin Belousov <kostikbel@gmail.com>, arch@FreeBSD.org Subject: Re: aio_mlock(2) system call Message-ID: <20130604212917.GA72412@stack.nl> In-Reply-To: <20130604113035.GV67170@glebius.int.ru> References: <20130603100618.GH67170@FreeBSD.org> <20130603161255.GM3047@kib.kiev.ua> <20130604113035.GV67170@glebius.int.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jun 04, 2013 at 03:30:35PM +0400, Gleb Smirnoff wrote:
> Updated patch.
> [snip]
> Index: lib/libc/sys/Symbol.map
> ===================================================================
> --- lib/libc/sys/Symbol.map (revision 251369)
> +++ lib/libc/sys/Symbol.map (working copy)
> @@ -378,6 +378,7 @@ FBSD_1.2 {
> };
>
> FBSD_1.3 {
> + aio_mlock;
> accept4;
> bindat;
> cap_fcntls_get;
This should probably be in alphabetical order.
> Index: lib/libc/sys/aio_mlock.2
> ===================================================================
> --- lib/libc/sys/aio_mlock.2 (revision 0)
> +++ lib/libc/sys/aio_mlock.2 (working copy)
> [snip]
> +.Sh PORTABILITY
> +The
> +.Fn aio_mlock
> +system call is a
> +.Fx
> +extension, and shouldn't be used in portable code.
Man pages should not use contractions.
> [snip]
> Index: sys/sys/aio.h
> ===================================================================
> --- sys/sys/aio.h (revision 251369)
> +++ sys/sys/aio.h (working copy)
> @@ -38,6 +38,7 @@
> #ifdef _KERNEL
> #define LIO_SYNC 0x3
> #endif
> +#define LIO_MLOCK 0x4
Is it intended that the new constant is available to userland, such as
for use in lio_listio(2)?
> [snip]
--
Jilles Tjoelker
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130604212917.GA72412>