Date: Wed, 26 Apr 2023 05:47:12 +0000 From: Colin Percival <cperciva@tarsnap.com> To: Kyle Evans <kevans@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 3a5855dd220b - main - gbde: stop rebuilding sha512 bits Message-ID: <01000187bc19fc1e-5504153f-04c8-4825-9a58-15782ac3d681-000000@email.amazonses.com> In-Reply-To: <202304260536.33Q5aqPA029814@gitrepo.freebsd.org> References: <202304260536.33Q5aqPA029814@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4/25/23 22:36, Kyle Evans wrote: > In the early days of gbde, it linked against libmd. Shortly after > conception, phk replaced ARC4 with SHA-512, but libmd did not have SHA2 > at the time thus he built a copy of sha2.c for gbde. > > Fast forward 3 years, cperciva adds SHA2 to libmd -- this makes gbde's > build of sha2.c redundant, but it's (understandably) overlooked. Let's > simplify the gbde build now and just assume that libmd includes the most > optimal implementation. Slight correction: I added *sha256* to libmd in 2005 (FreeBSD 6.0); markm added sha512 to libmd in 2011 (FreeBSD 9.0). -- Colin Percival FreeBSD Deputy Release Engineer & EC2 platform maintainer Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?01000187bc19fc1e-5504153f-04c8-4825-9a58-15782ac3d681-000000>