Date: Wed, 24 Aug 2016 13:16:34 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Eric van Gyzen <vangyzen@FreeBSD.org>, Ed Schouten <ed@nuxi.nl> Cc: svn-src-head@freebsd.org, jilles@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Ed Schouten <ed@freebsd.org> Subject: Re: svn commit: r303988 - head/lib/libc/gen Message-ID: <b53255ae-9afc-dbee-1b60-d3b9619dde3c@FreeBSD.org> In-Reply-To: <62adcb77-490e-0691-0942-9218c1d55b68@FreeBSD.org> References: <201608120703.u7C73whf007189@repo.freebsd.org> <d23b295a-1902-193c-dee6-ba49ebd77280@FreeBSD.org> <9ae1c2eb-02ad-b8fe-6aff-7e17e955607a@FreeBSD.org> <CABh_MKkxD3OTF7VO9Rq_eZyqHPN%2BxVws3q3dsH2R3DfZ343kFw@mail.gmail.com> <2632f5f8-d765-3df7-74d7-da878eb4b7a8@FreeBSD.org> <CABh_MKm_YQ3bJD19Cz1vBCGr=YxuzctXV6F1iqMASkSx-PsVMw@mail.gmail.com> <d606b841-dda9-488e-ab35-a9289668d2c4@FreeBSD.org> <CABh_MKmg9XqSg44P8i_S0jit_2tV8-Zyknu6gefMaxXN9piyxQ@mail.gmail.com> <62adcb77-490e-0691-0942-9218c1d55b68@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rsxs83XSIVWCo1inh3cIOc2KxDe14cFWb Content-Type: multipart/mixed; boundary="LBLMdnBaefR9SQIIAmJBrbMPlngg7Heif" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Eric van Gyzen <vangyzen@FreeBSD.org>, Ed Schouten <ed@nuxi.nl> Cc: svn-src-head@freebsd.org, jilles@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Ed Schouten <ed@freebsd.org> Message-ID: <b53255ae-9afc-dbee-1b60-d3b9619dde3c@FreeBSD.org> Subject: Re: svn commit: r303988 - head/lib/libc/gen References: <201608120703.u7C73whf007189@repo.freebsd.org> <d23b295a-1902-193c-dee6-ba49ebd77280@FreeBSD.org> <9ae1c2eb-02ad-b8fe-6aff-7e17e955607a@FreeBSD.org> <CABh_MKkxD3OTF7VO9Rq_eZyqHPN+xVws3q3dsH2R3DfZ343kFw@mail.gmail.com> <2632f5f8-d765-3df7-74d7-da878eb4b7a8@FreeBSD.org> <CABh_MKm_YQ3bJD19Cz1vBCGr=YxuzctXV6F1iqMASkSx-PsVMw@mail.gmail.com> <d606b841-dda9-488e-ab35-a9289668d2c4@FreeBSD.org> <CABh_MKmg9XqSg44P8i_S0jit_2tV8-Zyknu6gefMaxXN9piyxQ@mail.gmail.com> <62adcb77-490e-0691-0942-9218c1d55b68@FreeBSD.org> In-Reply-To: <62adcb77-490e-0691-0942-9218c1d55b68@FreeBSD.org> --LBLMdnBaefR9SQIIAmJBrbMPlngg7Heif Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 8/24/16 1:12 PM, Eric van Gyzen wrote: > On 08/24/2016 15:01, Ed Schouten wrote: >> 2016-08-24 21:53 GMT+02:00 Bryan Drewery <bdrewery@freebsd.org>: >>> Is it possible to cause the use of these old prototypes to print a >>> warning and note that they are deprecated/unsafe? >> >> That's a good question. In theory, we could annotate these functions >> with __attribute__((__deprecated__)): >> >> https://gcc.gnu.org/onlinedocs/gcc-3.3.4/gcc/Type-Attributes.html >> >> But I'm actually too afraid to use it. In the worst case it may cause >> the compiler to generate a warning even when basename()/dirname() is >> used correctly, as __old_* will still be part of the compiled >> expression. >=20 > Could __warn_references() be used, as libc currently does for gets() an= d > others? >=20 > Eric >=20 /usr/include/stdio.h:extern char *gets (char *__s) __wur __attribute_deprecated__; /usr/include/x86_64-linux-gnu/sys/cdefs.h:# define __attribute_deprecated__ __attribute__ ((__deprecated__)) __wur being warning about unused result. As for actually using it here, I tried adding it onto the _old_dirname/basename prototypes. It produces an error, fine, in the bootstrap build for xinstall it would not error, great. However, for building xinstall on head where it will not use the __old_dirname and will use the new dirname@FBSD_1.5, it _still_ complains about using the __old_dirname() prototype via __generic and errors in the wrong case. --=20 Regards, Bryan Drewery --LBLMdnBaefR9SQIIAmJBrbMPlngg7Heif-- --rsxs83XSIVWCo1inh3cIOc2KxDe14cFWb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJXvgCjAAoJEDXXcbtuRpfPB0YH+gI3fhBCQoZnxfwd/DwqI9U4 Q2+uttqgmRndF3zbUresflVjbb3KNprPOWwc/YMgB6L5bpz9E5hctWqYEH/Q7AoL rXiRmtKoGx1A2TNcso8wP2zy5971ZQQJsVHwflDQDnJtFspHnbTAxylLs4U2beAq wVq+ICWWcEG3e8OUPshvulJZCQpJiATt1ytgG1iTmbcyEemakpc3onsDbYoyjlDY FZbhUkEhw0dfNL8esbUc0tBHlLSc4qH9y7AoQdC7ATOKHVpgj64Jufqos3W2HVwe 5zyS5SxbZ1vp4QjM5KwlBAkXbYIVfXGIHwyUSaC/7esaNzfxYyYDG5ikfkfWCHY= =OirR -----END PGP SIGNATURE----- --rsxs83XSIVWCo1inh3cIOc2KxDe14cFWb--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b53255ae-9afc-dbee-1b60-d3b9619dde3c>