Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 16 Oct 2019 15:56:16 +0200
From:      Hans Petter Selasky <hps@selasky.org>
To:        Emmanuel Vadot <manu@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r353642 - head/sys/dev/usb/controller
Message-ID:  <58b56930-36d4-8e09-366e-a425c959b408@selasky.org>
In-Reply-To: <201910161353.x9GDrrUq044752@repo.freebsd.org>
References:  <201910161353.x9GDrrUq044752@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2019-10-16 15:53, Emmanuel Vadot wrote:
> Author: manu
> Date: Wed Oct 16 13:53:53 2019
> New Revision: 353642
> URL: https://svnweb.freebsd.org/changeset/base/353642
> 
> Log:
>    dwc3: Use a pair of ()'s around arguments for some macros
>    
>    Reported by:	hselasky
>    MFC after:	1 week
>    X-MFC-With:	r353533
> 
> Modified:
>    head/sys/dev/usb/controller/dwc3.h
> 
> Modified: head/sys/dev/usb/controller/dwc3.h
> ==============================================================================
> --- head/sys/dev/usb/controller/dwc3.h	Wed Oct 16 13:30:28 2019	(r353641)
> +++ head/sys/dev/usb/controller/dwc3.h	Wed Oct 16 13:53:53 2019	(r353642)
> @@ -92,8 +92,8 @@
>   #define	 DWC3_GUSB3PIPECTL0_PHYSOFTRST		(1 << 31)
>   #define	 DWC3_GUSB3PIPECTL0_DELAYP1TRANS	(1 << 18)
>   
> -#define	DWC3_GTXFIFOSIZ(x)	(0xc300 + 0x4 * x)
> -#define	DWC3_GRXFIFOSIZ(x)	(0xc380 + 0x4 * x)
> +#define	DWC3_GTXFIFOSIZ(x)	(0xc300 + 0x4 * (x))
> +#define	DWC3_GRXFIFOSIZ(x)	(0xc380 + 0x4 * (x))
>   #define	DWC3_GEVNTADRLO0		0xc400
>   #define	DWC3_GEVNTADRHI0		0xc404
>   #define	DWC3_GEVNTSIZ0		0xc408
> 

One more:

86 	#define  DWC3_GUSB2PHYCFG0_PHYSEL(x)            ((x >> 7) & 0x1) 
    /* 0 = USB2.0, 1 = USB1.1 */

--HPS



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?58b56930-36d4-8e09-366e-a425c959b408>