Date: Thu, 22 Jan 2015 11:16:20 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r277489 - head/sys/kern Message-ID: <20150122091620.GX42409@kib.kiev.ua> In-Reply-To: <20150121182444.GG15484@FreeBSD.org> References: <201501211632.t0LGWtOR098070@svn.freebsd.org> <20150121182444.GG15484@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 21, 2015 at 09:24:44PM +0300, Gleb Smirnoff wrote: > On Wed, Jan 21, 2015 at 04:32:55PM +0000, Konstantin Belousov wrote: > K> Author: kib > K> Date: Wed Jan 21 16:32:54 2015 > K> New Revision: 277489 > K> URL: https://svnweb.freebsd.org/changeset/base/277489 > K> > K> Log: > K> Do not assert that the new pipepair mutex is not initialized. The > K> backing memory contains garbage and might trigger the assertion. > > I have touched dozen of places in kernel where I do explicit M_ZERO on > allocation just to satisfy later assertion in the mtx_init. Is the > correct fix to use MTX_NEW? I think MTX_NEW is better. Note that this flag is just a month old, it was added by dchagin in r275751.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150122091620.GX42409>