Date: Sun, 11 Mar 2001 15:28:13 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: Dag-Erling Smorgrav <des@ofug.org> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/linux linux_machdep.c Message-ID: <XFMail.010311152813.jhb@FreeBSD.org> In-Reply-To: <xzp7l1w2n6c.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11-Mar-01 Dag-Erling Smorgrav wrote: > John Baldwin <jhb@FreeBSD.org> writes: >> Log: >> Create clone'd linux processes as stopped processes at first and don't >> actually make them runnable until after the emulator layer has had a >> chance >> to perform fixups. > > This commit is wrong: rfork() masks away RFSTOPPED, so fork1() queues > the process, then linux_clone() queues it once again. This would have > gotten caught if runq_add() asserted that it didn't get passed an > already-queued process. Is RFSTOPPED in RFKERNELONLY then? I thought only RFHIGHPID was in RFKERNELONLY. *sigh* Well, looks like I need to hack up rfork somehow, because this commit is correct, but the linux compatibility layer needs a way to bypass the userland checks that rfork provides. Possibly a rfork1(). > The corresponding commit to src/sys/alpha/linux/linux_machdep.c is of > course also incorrect. > > DES > -- > Dag-Erling Smorgrav - des@ofug.org -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010311152813.jhb>