Date: Fri, 12 Mar 2010 18:19:31 +0300 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Julian Elischer <julian@elischer.org> Cc: src-committers@FreeBSD.org, Juli Mallett <jmallett@FreeBSD.org>, svn-src-all@FreeBSD.org, Qing Li <qingli@FreeBSD.org>, Robert Watson <rwatson@FreeBSD.org>, svn-src-head@FreeBSD.org Subject: Re: svn commit: r205024 - head/sys/net Message-ID: <20100312151931.GS37184@FreeBSD.org> In-Reply-To: <4B99EA09.80108@elischer.org> References: <201003111756.o2BHukJu042449@svn.freebsd.org> <alpine.BSF.2.00.1003112128020.97017@fledge.watson.org> <9ace436c1003111530s3bd0de9cq451671909fb6aa64@mail.gmail.com> <eaa228be1003111535s12febe62x91124b0a015fd0ff@mail.gmail.com> <9ace436c1003111539t2af8439cn315c695d4b90e28d@mail.gmail.com> <eaa228be1003111607s4e78fe73k26a67161642d510d@mail.gmail.com> <4B99EA09.80108@elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 11, 2010 at 11:15:21PM -0800, Julian Elischer wrote: J> Juli Mallett wrote: J> > On Thu, Mar 11, 2010 at 15:39, Qing Li <qingli@freebsd.org> wrote: J> >> I guess it's a good time to clean things up. The if_link_state code has been J> >> around for quite some time, either it be fully utilized or not be there at all. J> >> The inconsistency is the root cause. J> > J> > Sure. There is an increasing amount of stuff that network drivers are J> > expected to do, but they work without doing them. It's easy to think J> > you have a functioning network driver and that you can get by without J> > adding support for media changes and link status reporting, etc. J> > J> >> I will try going through these tonight and hopefully the fix all take a J> >> common approach. J> J> probably should add a flag that means "we have media state" J> and if it is not set, assume it is always on. We've got LINK_STATE_UNKNOWN, we can just initialize if_link_state to this value in ether_ifattach(). And Qing should treat this value as LINK_STATE_UP in routing decision until better times. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100312151931.GS37184>