Date: Sat, 17 Nov 2012 08:38:31 +1100 From: Peter Jeremy <peter@rulingia.com> To: Dimitry Andric <dim@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, Adrian Chadd <adrian@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r242625 - in head/sys: dev/ale dev/ata dev/ata/chipsets dev/ath/ath_hal/ar5212 dev/bge dev/cas dev/dc dev/flash dev/fxp dev/gem dev/lge dev/mii dev/nge dev/pci dev/re dev/sis dev/ste de... Message-ID: <20121116213831.GW36898@server.rulingia.com> In-Reply-To: <5098416C.3040802@FreeBSD.org> References: <201211051916.qA5JGRDr064585@svn.freebsd.org> <CAJ-VmokCiKJvUriXgDO91-2u4RgwyffHcCzgGW_wFxuOtkvpbg@mail.gmail.com> <5098416C.3040802@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--O8XZ+2Hy8Kj8wLPZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2012-Nov-05 23:45:00 +0100, Dimitry Andric <dim@FreeBSD.org> wrote: >On 2012-11-05 23:36, Adrian Chadd wrote: >> I'm fine with the change, but why didn't you run this by the various >> driver owners first before doing a drive-by commit? > >The change was trivial, and did not cause any binary difference. I see >no reason to bother 20 different maintainers with something like this, >except bureaucratic ones... :) A bit belated but I think you've missed the most important reason why you should warn maintainers: You can be creating additional effort for maintainers. There is an ongoing push to make head more stable by pushing experimental development into "private" branches which can then be merged back to head once the functionality is stable. Whilst there may not be a binary difference, you are creating source changes. If you've changed something that a maintainer is actively working on, they need to take the time to work out if the change is still relevant and whether it impacts the testing they have done. --=20 Peter Jeremy --O8XZ+2Hy8Kj8wLPZ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlCmslcACgkQ/opHv/APuIcjhQCfdfojhFm65IzT8IwUrn09pxHb cT0AnRkrdRX97DAF1WSlD9YpEhpwZDiG =PLKu -----END PGP SIGNATURE----- --O8XZ+2Hy8Kj8wLPZ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121116213831.GW36898>