Date: Thu, 21 Nov 2019 04:23:38 +0000 From: Glen Barber <gjb@freebsd.org> To: Pete Wright <pete@nomadlogic.org> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: breakage at usr.sbin/jail/Makefile Message-ID: <20191121042338.GM5599@FreeBSD.org> In-Reply-To: <38318920-7d3b-ee08-b0d0-d6e04e03c6a3@nomadlogic.org> References: <0e3dd332-91d7-0aa1-43cb-43528db7c63a@nomadlogic.org> <20191121041317.GL5599@FreeBSD.org> <38318920-7d3b-ee08-b0d0-d6e04e03c6a3@nomadlogic.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--FC52J0nKTzya17Ed
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Wed, Nov 20, 2019 at 08:18:52PM -0800, Pete Wright wrote:
>=20
>=20
> On 11/20/19 8:13 PM, Glen Barber wrote:
> > On Wed, Nov 20, 2019 at 07:57:57PM -0800, Pete Wright wrote:
> > > Hello,
> > > looks like some of the recent commits to usr.sbin/jail/Makefile has b=
roken
> > > CURRENT.=A0 I am getting this error when attempting a buildworld:
> > >=20
> > > =3D=3D=3D> usr.sbin/jail (cleandir)
> > > make[4]: "/usr/home/pete/git/freebsd/usr.sbin/jail/Makefile" line 21:
> > > Malformed conditional (${LINKER_TYPE} =3D=3D "bfd" && ${MACHINE} =3D=
=3D "riscv")
> > > make[4]: Fatal errors encountered -- cannot continue
> > > make[4]: stopped in /usr/home/pete/git/freebsd/usr.sbin/jail
> > > *** [cleandir_subdir_usr.sbin/jail] Error code 1
> > >=20
> > >=20
> > > here's the code in question:
> > > =A018 # workaround for GNU ld (GNU Binutils) 2.33.1:
> > > =A019 #=A0=A0 relocation truncated to fit: R_RISCV_GPREL_I against `=
=2ELANCHOR2'
> > > =A020 # https://bugs.freebsd.org/242109
> > > =A021 .if ${LINKER_TYPE} =3D=3D "bfd" && ${MACHINE} =3D=3D "riscv"
> > > =A022 CFLAGS+=3D-Wl,--no-relax
> > > =A023 .endif
> > >=20
> > >=20
> > > looks like Ed Maste caught this already in the
> > > https://bugs.freebsd.org/242109 but wanted to flag it here as well in=
case
> > > anyone else runs into this in the hopes it saves some debugging time =
:)
> > >=20
> > Reverted out of frustration in r354935.
>=20
> thanks!
>=20
> the issue seems to be on my amd64 system ${LINKER_TYPE} is not defined.=
=A0 i was
> contemplating suggesting updating the .if clause in the Makefile like so:
>=20
> .if defined($LINKER_TYPE}) && ${LINKER_TYPE} =3D=3D "bfd" && ${MACHINE} =
=3D=3D
> "riscv"
>=20
>=20
> it allows things to compile on my end, but i'm not sure this is best way =
to
> resolve this issue.
>=20
Not necessarily, there were followups to the original commit that leaned
in different directions. But, nonetheless, I reverted the offending
commits because allowing head to be broken for hours is absurd, and
I personally do not tolerate it when I can resolve it.
Glen
--FC52J0nKTzya17Ed
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEjRJAPC5sqwhs9k2jAxRYpUeP4pMFAl3WEUoACgkQAxRYpUeP
4pNHnQ//b0c3NDy+WfjrDQQEl7QttLzLT6qHajZYW7pwOTyDT2BnqBNypWkMgNaq
laZ0F+Rs8gjV1uGaYeJ+lrtSnCfbVxPXDy6pRuNrMKRyNEbzD+rVTgHYq+fcIa52
k/KIwykWdb4hKnrT90Fhq+ClszX54SJSXOHeIf8h3BeQcl3htaouv4gqt9qat5Ad
fPkjwBg2ApplkpDNaTz8I95dXJezV/afpDHnDbIna48ej9g3o4fW38ss27ZamV11
QmkJJneypGm32/QaKa/jtRQVZqVcWSE83UdjlOOWgDgK9UfX7BnN07UiFGLkRZVi
Nf+H37SXdKVq5qjbSOHQr79Z1ge2Wa1Q1JJl/UchPdAtE5icrmEHmGgPlcGZ8KZk
nMu8cYon7dmY7YDCtZvpFWd6P8uqeydf+pWtG+0pRiOz4x1B839+GYhuXmg4vZVo
qzXBA/s6W/KGWJDditdOv+7AVLKUUSyqSi/GKSouUgeHUULnZl9lcs7z5BuJi5t1
E11wXxb+kUPkhd9ccLV0ny7XKXf/hnv4RSDOp9QXF3frYv0PbdJS1X8awJqdzieW
MKgEROg31m69fdITrV/6HX4GI5hQHWYXJT7Vlgmbm7MBJR7tTVS0PUOMwlZtcjDp
duTZ8yd4XZLsu64S2zYdK74XrHkRTLxFh6ZA9Z3uklSmTm8SXcQ=
=OFib
-----END PGP SIGNATURE-----
--FC52J0nKTzya17Ed--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191121042338.GM5599>