Date: Thu, 11 Apr 2002 19:25:10 -0700 (PDT) From: Dima Dorfman <dd@FreeBSD.org> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: ports/net/dictd Makefile Message-ID: <200204120225.g3C2PB609291@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
dd 2002/04/11 19:25:10 PDT
Modified files:
net/dictd Makefile
Log:
The regexp used to change T_USER to T_USERNAME only works if the
symbol is preceded by whitespace. However, on line 64 of servscan.l,
the symbol is preceded by a parenthesis, so it is left alone. On
i386, T_USER is defined, so the build proceeds, but there may still be
adverse side effects due to that routine returning the wrong thing in
some cases. The bandaid is to fix the regexp to catch the case where
T_USER is used after a parenthesis--this is what's being committed. The
real fix is either to make the author use T_USERNAME for us, or,
preferably, don't define T_USER when sys/param.h is included since
T_USER is in the application namespace.
Approved by: maintainer timeout
Revision Changes Path
1.9 +2 -2 ports/net/dictd/Makefile
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200204120225.g3C2PB609291>