Date: Mon, 25 Aug 2014 18:09:44 +0200 From: =?windows-1252?Q?Jean-S=E9bastien_P=E9dron?= <dumbbell@FreeBSD.org> To: John Baldwin <jhb@freebsd.org>, Adrian Chadd <adrian@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r270516 - head/sys/dev/drm2/i915 Message-ID: <53FB5FC8.4030105@FreeBSD.org> In-Reply-To: <2177184.NMfUXrE71G@ralph.baldwin.cx> References: <201408250503.s7P53Axo057720@svn.freebsd.org> <2177184.NMfUXrE71G@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
On 25.08.2014 16:26, John Baldwin wrote: > Also, is leaving around the #if 0'd Linux version something the drm2 code does > in general or was that unique to this patch? If the latter, we should remove > the duplicate #if 0 code (list_for_each, etc.) There's no actual consensus, I guess. In my DRM 3.8 branch, where I try to reduce the diff with Linux, I try to provide wrappers and keep the Linux code. Before that branch is merged, I'm in favor of keeping the Linux code around (but maybe use #ifdef __FreeBSD__) to keep an history of what was originally ported. -- Jean-Sébastien Pédron
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53FB5FC8.4030105>