Date: Thu, 7 Sep 2023 18:19:23 +0000 From: Brooks Davis <brooks@freebsd.org> To: Colin Percival <cperciva@freebsd.org> Cc: Zhenlei Huang <zlei@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: 1926d5cef6ea - main - init_main: Record completed SYSINITs Message-ID: <ZPoUK6UOd7S4T1Vo@spindle.one-eyed-alien.net> In-Reply-To: <dc68e74c-43ff-31ad-42f8-6790eddc0301@freebsd.org> References: <202309061837.386Ib5AK086264@gitrepo.freebsd.org> <5BC96D9F-E4C4-4D34-B7B3-41576AD296DA@FreeBSD.org> <dc68e74c-43ff-31ad-42f8-6790eddc0301@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 06, 2023 at 06:46:59PM -0700, Colin Percival wrote: > On 9/6/23 18:12, Zhenlei Huang wrote: > > > On Sep 7, 2023, at 2:37 AM, Colin Percival <cperciva@FreeBSD.org> wrote: > > > init_main: Record completed SYSINITs > > > > > > When removing them from sysinit_list, append them to sysinit_done_list; > > > print this list from 'show sysinit' along with the list of future > > > sysinits. > > > > So the `sysinit_done_list` is for DDB only. > > Well... sort of. You can open up kgdb and run 'p sysinit_done_list'. > > > > static STAILQ_HEAD(sysinitlist, sysinit) sysinit_list; > > > +static struct sysinitlist sysinit_done_list = > > > + STAILQ_HEAD_INITIALIZER(sysinit_done_list); > > > > Then it should be wrapped around with #ifdef DDB and #endif > I considered that, but since we're literally talking about 2 pointers of > memory I figured it wasn't worth making it conditional. IMO loss of the run order in a dump was a (minor) regression so this should be unconditionally available. -- Brooks
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZPoUK6UOd7S4T1Vo>