Date: Wed, 30 Nov 2005 20:40:40 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom/mirror g_mirror.c src/sys/geom/vinum geom_vinum_drive.c src/sys/geom/label g_label_iso9660.c g_label_msdosfs.c g_label_ufs.c src/sys/geom/raid3 g_raid3.c src/sys/geom/uzip g_uzip.c src/sys/geom/eli g_eli.c src/sys/geom ... Message-ID: <20051130194039.GI79912@garage.freebsd.pl> In-Reply-To: <200511301924.jAUJOpHL061333@repoman.freebsd.org> References: <200511301924.jAUJOpHL061333@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Wed, Nov 30, 2005 at 07:24:51PM +0000, Maxim Sobolev wrote: +> sobomax 2005-11-30 19:24:51 UTC +> +> FreeBSD src repository +> +> Modified files: +> sys/geom/mirror g_mirror.c +> sys/geom/vinum geom_vinum_drive.c +> sys/geom/label g_label_ufs.c g_label_iso9660.c +> g_label_msdosfs.c +> sys/geom/raid3 g_raid3.c +> sys/geom/uzip g_uzip.c +> sys/geom/eli g_eli.c +> sys/geom geom_aes.c geom_apple.c geom_bsd.c +> geom_fox.c geom_gpt.c geom_mbr.c +> geom_pc98.c geom_sunlabel.c +> geom_vol_ffs.c +> Log: +> Check for g_read_data(9) errors properly: +> +> o The only indication of error condition is NULL value returned by +> the function; +> +> o value pointed to by error argument is undefined in the case when +> operation completes successfully. If you decided to clean this up, please make it a complete clean-up, so noone has to clean up after you:) The thing I'm talking about is that when you don't plan to use error value, you can just pass NULL as the last argument for g_read_data(9). There are probably few places now where 'error' variable is unused. -- Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDjgA3ForvXbEpPzQRAvVEAKDAT3oerbJybZE3i1PpknKPOO0OrQCdGrs5 2Hqjp4KRhLJW969YvGFuzUM= =WeCu -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051130194039.GI79912>