Date: Tue, 14 Oct 2014 22:26:38 +0100 From: Miguel Clara <miguelmclara@gmail.com> To: Tomek <tomek@apostata.org> Cc: chromium@freebsd.org Subject: Re: [Bug 193725] chromium-37 Latin accent keys are not working Message-ID: <CADGo8CXqhhXTg7vW%2BKftsbr3V=3h1VYAwiPLo31E2wTOWOYW=g@mail.gmail.com> In-Reply-To: <319a0f139f45ae0b0471679e65ab1d58@webmail.olejniczak.info> References: <bug-193725-28929@https.bugs.freebsd.org/bugzilla/> <bug-193725-28929-4inSSwq203@https.bugs.freebsd.org/bugzilla/> <319a0f139f45ae0b0471679e65ab1d58@webmail.olejniczak.info>
next in thread | previous in thread | raw e-mail | index | archive | help
Testing this now, thanks for the patch
Melhores Cumprimentos // Best Regards
-----------------------------------------------
*Miguel Clara*
*IT - Sys Admin & Developer*
*E-mail: *miguelmclara@gmail.com
www.linkedin.com/in/miguelmclara/
On Tue, Oct 14, 2014 at 9:04 PM, Tomek <tomek@apostata.org> wrote:
> Hi,
>
> > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193725
> >
> > --- Comment #6 from miguelmclara@gmail.com ---
> > Same in version 38...
> >
> > This really makes the browser unusable to me and probably most users hat
> need
> > the same characters.
>
> These three patches should fix the compose key - please test it (I'm not
> normally using compose key myself).
>
> --- chrome/browser/ui/browser_command_http://controller.cc.orig
> 2014-10-14 21:32:48.000000000 +0200
> +++ chrome/browser/ui/browser_command_http://controller.cc 2014-10-14
> 21:22:15.000000000 +0200
> @@ -67,7 +67,7 @@
> #include "chrome/browser/ui/browser_commands_chromeos.h"
> #endif
>
> -#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
> +#if defined(OS_LINUX) && !defined(OS_CHROMEOS) || defined(OS_BSD)
> #include "ui/events/linux/text_edit_key_bindings_delegate_auralinux.h"
> #endif
>
> @@ -279,7 +279,7 @@
> if (window()->IsFullscreen() && command_id == IDC_FULLSCREEN)
> return true;
>
> -#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
> +#if defined(OS_LINUX) && !defined(OS_CHROMEOS) || defined(OS_BSD)
> // If this key was registered by the user as a content editing hotkey, then
> // it is not reserved.
> ui::TextEditKeyBindingsDelegateAuraLinux* delegate =
>
> --- ui/base/ime/input_method_http://factory.cc.orig 2014-10-14
> 21:31:49.000000000 +0200
> +++ ui/base/ime/input_method_http://factory.cc 2014-10-14
> 21:26:34.000000000 +0200
> @@ -14,7 +14,7 @@
> #include "ui/base/ime/remote_input_method_win.h"
> #elif defined(OS_MACOSX)
> #include "ui/base/ime/input_method_mac.h"
> -#elif defined(USE_AURA) && defined(OS_LINUX) && !defined(OS_CHROMEOS)
> +#elif defined(USE_AURA) && defined(OS_LINUX) && !defined(OS_CHROMEOS) ||
> defined(OS_BSD)
> #include "ui/base/ime/input_method_auralinux.h"
> #else
> #include "ui/base/ime/input_method_minimal.h"
> @@ -47,7 +47,7 @@
> return scoped_ptr<InputMethod>(new InputMethodWin(delegate, widget));
> #elif defined(OS_MACOSX)
> return scoped_ptr<InputMethod>(new InputMethodMac(delegate));
> -#elif defined(USE_AURA) && defined(OS_LINUX) && !defined(OS_CHROMEOS)
> +#elif defined(USE_AURA) && defined(OS_LINUX) && !defined(OS_CHROMEOS) ||
> defined(OS_BSD)
> return scoped_ptr<InputMethod>(new InputMethodAuraLinux(delegate));
> #else
> return scoped_ptr<InputMethod>(new InputMethodMinimal(delegate));
>
> --- content/browser/renderer_host/render_widget_host_view_
> http://aura.cc.orig 2014-10-14 21:55:07.000000000 +0200
> +++ content/browser/renderer_host/render_widget_host_view_http://aura.cc
> 2014-10-14 21:26:40.000000000 +0200
> @@ -88,7 +88,7 @@
> #include "ui/gfx/win/dpi.h"
> #endif
>
> -#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
> +#if defined(OS_LINUX) && !defined(OS_CHROMEOS) || defined(OS_BSD)
> #include "content/common/input_messages.h"
> #include "ui/events/linux/text_edit_command_auralinux.h"
> #include "ui/events/linux/text_edit_key_bindings_delegate_auralinux.h"
> @@ -2418,7 +2418,7 @@
>
> void RenderWidgetHostViewAura::ForwardKeyboardEvent(
> const NativeWebKeyboardEvent& event) {
> -#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
> +#if defined(OS_LINUX) && !defined(OS_CHROMEOS) || defined(OS_BSD)
> ui::TextEditKeyBindingsDelegateAuraLinux* keybinding_delegate =
> ui::GetTextEditKeyBindingsDelegate();
> std::vector<ui::TextEditCommandAuraLinux> commands;
>
> --
> Best Wishes
> Tomek
> _______________________________________________
> freebsd-chromium@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-chromium
> To unsubscribe, send any mail to "freebsd-chromium-unsubscribe@freebsd.org
> "
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADGo8CXqhhXTg7vW%2BKftsbr3V=3h1VYAwiPLo31E2wTOWOYW=g>