Date: Mon, 6 Feb 2017 11:04:46 -0600 From: Eric van Gyzen <vangyzen@FreeBSD.org> To: Mark Martinec <Mark.Martinec+freebsd@ijs.si> Cc: freebsd-stable@freebsd.org Subject: Re: net.inet.udp.log_in_vain strange syslog reports Message-ID: <7dca33f9-e817-7d79-bddd-332e745a1c05@FreeBSD.org> In-Reply-To: <667fa3e1dd8e7cebbf4566467a7987bf@ijs.si> References: <76681a24b7935674585b5ac585f4575c@ijs.si> <ab6cbfbb-83c3-e27d-0d26-50313f171bf0@FreeBSD.org> <667fa3e1dd8e7cebbf4566467a7987bf@ijs.si>
next in thread | previous in thread | raw e-mail | index | archive | help
On 02/06/2017 10:19, Mark Martinec wrote: > > One minor nit: > instead of a hack: > > char src[4*sizeof "123"]; > char dst[4*sizeof "123"]; > > it would be cleaner and in sync with the equivalent code in > sys/netinet6/udp6_usrreq.c > to use the INET_ADDRSTRLEN constant (from sys/netinet/in.h, value 16): > > char src[INET_ADDRSTRLEN]; > char dst[INET_ADDRSTRLEN]; Agreed. > Hope the fix finds its way into 11.1 (or better yet, as a patch level in > 10.0). > Should I open a bug report? It will quite likely get into 11.1. As for a 10.x patch, you would have to ask re@ (I think), but I doubt it. These messages are really just informative and can't be used for any filtering, since the source address could be spoofed. Eric
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7dca33f9-e817-7d79-bddd-332e745a1c05>