Date: Wed, 11 Dec 1996 13:16:28 +1100 From: Bruce Evans <bde@zeta.org.au> To: jkh@time.cdrom.com, toor@dyson.iquest.net Cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, dyson@freefall.freebsd.org Subject: Re: cvs commit: src/sys/ufs/ufs ufs_readwrite.c Message-ID: <199612110216.NAA27773@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>> #ifdef MMAP_ACTUALLY_BOUGHT_US_PERFORMANCE >> .. >> #endif >> >> Be more appropriate? >> >For us, since 2.1.X, I think that your suggested name is more accurate. >Also, I do think that we'll generally see marginally improved perf now >since the recent change. Note that if you enable it in your private >sources, you will likely want to do the madvise -- if you don't, the >perf will be just as lousy as it was before. There are a number of clones of the cmp and cp code in the tree. E.g., xinstall.c has a version of cmp with an arbitrary 8MB limit like cp. It's not clear that the mmap() version is faster than the read() version. The read() version uses the semi-arbitrary buffer size of MAXBSIZE. This may be too big for starting up (it is too big if the files compare unequal near the start, but they are likely to compare equal). `install' sometimes installs the source, so it should attempt to keep the source cached. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199612110216.NAA27773>