Date: Thu, 25 Apr 2024 13:24:07 -0600 From: Warner Losh <imp@bsdimp.com> To: Colin Percival <cperciva@tarsnap.com> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org>, =?UTF-8?Q?Klaus_K=C3=BCchemann?= <maciphone2@googlemail.com> Subject: Re: git: 1bd4f769caf8 - main - add dtb support for RPI CM4, CM4s, CM4_ioBoard Message-ID: <CANCZdfp0S4bqAMjj1HQt3gHwr56T%2B_tyo7w1xi5GG1pXPWAOzA@mail.gmail.com> In-Reply-To: <0100018f169ec80a-47d419c2-2cd6-4ee1-89da-3f4782429089-000000@email.amazonses.com> References: <202404192311.43JNBiVS059729@gitrepo.freebsd.org> <0100018f169ec80a-47d419c2-2cd6-4ee1-89da-3f4782429089-000000@email.amazonses.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Thu, Apr 25, 2024, 12:57 PM Colin Percival <cperciva@tarsnap.com> wrote: > On 4/19/24 16:11, Warner Losh wrote: > > add dtb support for RPI CM4, CM4s, CM4_ioBoard > > > > Signed-off-by: Klaus Küchemann <maciphone2@googlemail.com> > > Reviewed by: imp > > Pull Request: https://github.com/freebsd/freebsd-src/pull/1182 > > --- > > --- a/release/arm64/RPI.conf > > +++ b/release/arm64/RPI.conf > > -DTB="bcm2710-rpi-2-b.dtb bcm2710-rpi-3-b.dtb bcm2710-rpi-3-b-plus.dtb > bcm2710-rpi-cm3.dtb bcm2711-rpi-4-b.dtb" > > +DTB="bcm2710-rpi-2-b.dtb bcm2710-rpi-3-b.dtb bcm2710-rpi-3-b-plus.dtb > bcm2710-rpi-cm3.dtb \ > > + bcm2711-rpi-4-b.dtb bcm2711-rpi-cm4-io.dtb bcm2711-rpi-cm4.dtb > bcm2711-rpi-cm4s.dtb" > > This broke the RPI release build, since bcm2711-rpi-cm4s.dtb doesn't exist. > Is it provided by a port which we should add to the RPI build? > I thought it was in tree. I'll look into this and report back. Warner -- > Colin Percival > FreeBSD Release Engineering Lead & EC2 platform maintainer > Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid > [-- Attachment #2 --] <div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 25, 2024, 12:57 PM Colin Percival <<a href="mailto:cperciva@tarsnap.com">cperciva@tarsnap.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 4/19/24 16:11, Warner Losh wrote:<br> > add dtb support for RPI CM4, CM4s, CM4_ioBoard<br> > <br> > Signed-off-by: Klaus Küchemann <<a href="mailto:maciphone2@googlemail.com" target="_blank" rel="noreferrer">maciphone2@googlemail.com</a>><br> > Reviewed by: imp<br> > Pull Request: <a href="https://github.com/freebsd/freebsd-src/pull/1182" rel="noreferrer noreferrer" target="_blank">https://github.com/freebsd/freebsd-src/pull/1182</a><br>; > ---<br> > --- a/release/arm64/RPI.conf<br> > +++ b/release/arm64/RPI.conf<br> > -DTB="bcm2710-rpi-2-b.dtb bcm2710-rpi-3-b.dtb bcm2710-rpi-3-b-plus.dtb bcm2710-rpi-cm3.dtb bcm2711-rpi-4-b.dtb"<br> > +DTB="bcm2710-rpi-2-b.dtb bcm2710-rpi-3-b.dtb bcm2710-rpi-3-b-plus.dtb bcm2710-rpi-cm3.dtb \<br> > + bcm2711-rpi-4-b.dtb bcm2711-rpi-cm4-io.dtb bcm2711-rpi-cm4.dtb bcm2711-rpi-cm4s.dtb"<br> <br> This broke the RPI release build, since bcm2711-rpi-cm4s.dtb doesn't exist.<br> Is it provided by a port which we should add to the RPI build?<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">I thought it was in tree. I'll look into this and report back. </div><div dir="auto"><br></div><div dir="auto">Warner </div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> -- <br> Colin Percival<br> FreeBSD Release Engineering Lead & EC2 platform maintainer<br> Founder, Tarsnap | <a href="http://www.tarsnap.com" rel="noreferrer noreferrer" target="_blank">www.tarsnap.com</a> | Online backups for the truly paranoid<br> </blockquote></div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfp0S4bqAMjj1HQt3gHwr56T%2B_tyo7w1xi5GG1pXPWAOzA>