Date: Wed, 19 Nov 2025 12:56:18 -0700 From: Warner Losh <imp@bsdimp.com> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org>, Wanpeng Qian <wanpengqian@gmail.com> Subject: Re: git: 20e94950c54e - main - nvme: Notify namespace changes better Message-ID: <CANCZdfo%2BRckuTqmP==3R5rYtBHp8UA-k1QC0AjpD8OTum4SQvg@mail.gmail.com> In-Reply-To: <1osso5q5-74o7-pr61-q328-n6451nor36q4@mnoonqbm.arg> References: <691cdf72.35308.1c1c6fc1@gitrepo.freebsd.org> <1osso5q5-74o7-pr61-q328-n6451nor36q4@mnoonqbm.arg>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Wed, Nov 19, 2025, 11:01 AM Bjoern A. Zeeb < bzeeb-lists@lists.zabbadoz.net> wrote: > On Tue, 18 Nov 2025, Warner Losh wrote: > > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=20e94950c54e398049396647da36b9e2c3b639c1 > > > > commit 20e94950c54e398049396647da36b9e2c3b639c1 > > Author: Wanpeng Qian <wanpengqian@gmail.com> > > AuthorDate: 2025-11-18 15:24:23 +0000 > > Commit: Warner Losh <imp@FreeBSD.org> > > CommitDate: 2025-11-18 20:32:22 +0000 > > > > nvme: Notify namespace changes better > > > > When we get a namespace notification, we have to reconstrut the > > namespace to get the new identification data from the namespace. For > > each namespace in the AEN, we will reconstrict it before we call the > > notification. We also flag it as changed for the duration of the > change > > callback (prior versions of the patch needed to keep track, but we no > > longer do, so this bit may be removed). Note when we've seen the > > namespace so we can notify when it goes away. > > > > Co-authored-by: imp > > Differential Revision: https://reviews.freebsd.org/D33032 > > --- > > sys/dev/nvme/nvme.h | 7 +++++-- > > sys/dev/nvme/nvme_ctrlr.c | 12 +++++++++++- > > sys/dev/nvme/nvme_ns.c | 9 ++++++--- > > 3 files changed, 22 insertions(+), 6 deletions(-) > > Just replying to one of the multiple commits: > > It seems from somewhere a VIMAGE enabled kernel is pulling > in systm.h for memmove; LINT-NOVIMAGE fails without the below: > > % git diff > diff --git sys/dev/nvme/nvme.h sys/dev/nvme/nvme.h > index 8f7a7fbda14c..e17c2bf41a5a 100644 > --- sys/dev/nvme/nvme.h > +++ sys/dev/nvme/nvme.h > @@ -31,6 +31,7 @@ > > #ifdef _KERNEL > #include <sys/types.h> > +#include <sys/systm.h> > #endif > > #include <sys/param.h> > I'll take a look, but i didn’t think i added a memmove. Warner > -- > Bjoern A. Zeeb r15:7 > [-- Attachment #2 --] <div dir="auto"><div><br><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Wed, Nov 19, 2025, 11:01 AM Bjoern A. Zeeb <<a href="mailto:bzeeb-lists@lists.zabbadoz.net">bzeeb-lists@lists.zabbadoz.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Tue, 18 Nov 2025, Warner Losh wrote:<br> <br> > The branch main has been updated by imp:<br> ><br> > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=20e94950c54e398049396647da36b9e2c3b639c1" rel="noreferrer noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=20e94950c54e398049396647da36b9e2c3b639c1</a><br>; ><br> > commit 20e94950c54e398049396647da36b9e2c3b639c1<br> > Author: Wanpeng Qian <<a href="mailto:wanpengqian@gmail.com" target="_blank" rel="noreferrer">wanpengqian@gmail.com</a>><br> > AuthorDate: 2025-11-18 15:24:23 +0000<br> > Commit: Warner Losh <imp@FreeBSD.org><br> > CommitDate: 2025-11-18 20:32:22 +0000<br> ><br> > nvme: Notify namespace changes better<br> ><br> > When we get a namespace notification, we have to reconstrut the<br> > namespace to get the new identification data from the namespace. For<br> > each namespace in the AEN, we will reconstrict it before we call the<br> > notification. We also flag it as changed for the duration of the change<br> > callback (prior versions of the patch needed to keep track, but we no<br> > longer do, so this bit may be removed). Note when we've seen the<br> > namespace so we can notify when it goes away.<br> ><br> > Co-authored-by: imp<br> > Differential Revision: <a href="https://reviews.freebsd.org/D33032" rel="noreferrer noreferrer" target="_blank">https://reviews.freebsd.org/D33032</a><br>; > ---<br> > sys/dev/nvme/nvme.h | 7 +++++--<br> > sys/dev/nvme/nvme_ctrlr.c | 12 +++++++++++-<br> > sys/dev/nvme/nvme_ns.c | 9 ++++++---<br> > 3 files changed, 22 insertions(+), 6 deletions(-)<br> <br> Just replying to one of the multiple commits:<br> <br> It seems from somewhere a VIMAGE enabled kernel is pulling<br> in systm.h for memmove; LINT-NOVIMAGE fails without the below:<br> <br> % git diff<br> diff --git sys/dev/nvme/nvme.h sys/dev/nvme/nvme.h<br> index 8f7a7fbda14c..e17c2bf41a5a 100644<br> --- sys/dev/nvme/nvme.h<br> +++ sys/dev/nvme/nvme.h<br> @@ -31,6 +31,7 @@<br> <br> #ifdef _KERNEL<br> #include <sys/types.h><br> +#include <sys/systm.h><br> #endif<br> <br> #include <sys/param.h><br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">I'll take a look, but i didn’t think i added a memmove.</div><div dir="auto"><br></div><div dir="auto">Warner </div><div dir="auto"><div class="gmail_quote gmail_quote_container"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> -- <br> Bjoern A. Zeeb r15:7<br> </blockquote></div></div></div>help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfo%2BRckuTqmP==3R5rYtBHp8UA-k1QC0AjpD8OTum4SQvg>